Wholesale swap of packages/{core,viewer,editor,mcp} and apps/editor with the
versions from the private editor repo, which is the production source of truth.
Setup changes:
- packages/{core,viewer,editor} versions held at 0.7.0 baseline (matching
the most recent published release) so a bump=minor publishes 0.8.0
- packages/mcp held at 0.1.1 (never published; first publish will go through
the new release.yml flow)
- peerDependencies and devDependencies for inter-package @pascal-app/*
references pinned to ^0.7.0 instead of '*' / 'workspace:*' so they are
valid for npm consumers
- Root package.json: TypeScript bumped to 6.0.2, added overrides for
@types/react, @types/react-dom, @types/three to prevent JSX namespace
fragmentation across the workspace
- release.yml extended to also publish editor and mcp; 'both' option renamed
to 'all'; added a sync step that updates inter-package peerDeps/devDeps to
match the new versions on every bump (so viewer/editor/mcp tarballs always
reference the version of core they were built against)
- Root scripts gained release:editor and release:mcp shortcuts
Verification:
- bun install --frozen-lockfile is consistent
- packages/{core,viewer,mcp} build cleanly, dist/index.d.ts emitted
- packages/editor check-types reports 21 pre-existing errors, identical to
what private-editor currently reports
Open PRs against editor-v2 will need rebasing/conflict resolution.
202 lines
7.5 KiB
TypeScript
202 lines
7.5 KiB
TypeScript
import { beforeEach, describe, expect, test } from 'bun:test'
|
|
import { Client } from '@modelcontextprotocol/sdk/client/index.js'
|
|
import { InMemoryTransport } from '@modelcontextprotocol/sdk/inMemory.js'
|
|
import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'
|
|
import { SceneBridge } from '../../bridge/scene-bridge'
|
|
import { createSceneOperations } from '../../operations'
|
|
import {
|
|
InMemorySceneStore,
|
|
parseToolText,
|
|
type StoredTextContent,
|
|
} from '../scene-lifecycle/test-utils'
|
|
import { registerCreateFromTemplate } from './create-from-template'
|
|
import { registerCreateHouseFromBrief } from './create-house-from-brief'
|
|
import { registerListTemplates } from './list-templates'
|
|
|
|
describe('list_templates', () => {
|
|
let client: Client
|
|
|
|
beforeEach(async () => {
|
|
const server = new McpServer({ name: 'test', version: '0.0.0' })
|
|
registerListTemplates(server)
|
|
const [srvT, cliT] = InMemoryTransport.createLinkedPair()
|
|
client = new Client({ name: 'test-client', version: '0.0.0' })
|
|
await Promise.all([server.connect(srvT), client.connect(cliT)])
|
|
})
|
|
|
|
test('enumerates all three seed templates', async () => {
|
|
const result = await client.callTool({ name: 'list_templates', arguments: {} })
|
|
expect(result.isError).toBeFalsy()
|
|
const parsed = parseToolText(result.content as StoredTextContent[])
|
|
const list = parsed.templates as Array<{
|
|
id: string
|
|
name: string
|
|
description: string
|
|
nodeCount: number
|
|
}>
|
|
const ids = list.map((t) => t.id).sort()
|
|
expect(ids).toEqual(['empty-studio', 'garden-house', 'two-bedroom'])
|
|
for (const t of list) {
|
|
expect(typeof t.name).toBe('string')
|
|
expect(t.name.length).toBeGreaterThan(0)
|
|
expect(typeof t.description).toBe('string')
|
|
expect(t.nodeCount).toBeGreaterThan(0)
|
|
}
|
|
})
|
|
|
|
test('returns structuredContent matching the text payload', async () => {
|
|
const result = await client.callTool({ name: 'list_templates', arguments: {} })
|
|
expect(result.structuredContent).toBeDefined()
|
|
const structured = result.structuredContent as { templates: Array<{ id: string }> }
|
|
expect(structured.templates.length).toBe(3)
|
|
})
|
|
})
|
|
|
|
describe('create_from_template', () => {
|
|
let client: Client
|
|
let bridge: SceneBridge
|
|
let store: InMemorySceneStore
|
|
|
|
beforeEach(async () => {
|
|
bridge = new SceneBridge()
|
|
bridge.setScene({}, [])
|
|
store = new InMemorySceneStore()
|
|
const operations = createSceneOperations({ bridge, store })
|
|
const server = new McpServer({ name: 'test', version: '0.0.0' })
|
|
registerCreateFromTemplate(server, operations)
|
|
registerCreateHouseFromBrief(server, operations)
|
|
const [srvT, cliT] = InMemoryTransport.createLinkedPair()
|
|
client = new Client({ name: 'test-client', version: '0.0.0' })
|
|
await Promise.all([server.connect(srvT), client.connect(cliT)])
|
|
})
|
|
|
|
test('applies a template to the bridge with fresh ids', async () => {
|
|
const result = await client.callTool({
|
|
name: 'create_from_template',
|
|
arguments: { id: 'empty-studio' },
|
|
})
|
|
expect(result.isError).toBeFalsy()
|
|
const parsed = parseToolText(result.content as StoredTextContent[])
|
|
expect(parsed.templateId).toBe('empty-studio')
|
|
expect((parsed.rootNodeIds as string[]).length).toBeGreaterThan(0)
|
|
expect(parsed.nodeCount as number).toBeGreaterThan(0)
|
|
|
|
// Fresh ids — placeholder "site_empty" should not appear.
|
|
const bridgeNodes = Object.keys(bridge.getNodes())
|
|
expect(bridgeNodes).not.toContain('site_empty')
|
|
expect(bridgeNodes.length).toBeGreaterThan(0)
|
|
|
|
// Root id from the tool response should exist in the bridge.
|
|
for (const rid of parsed.rootNodeIds as string[]) {
|
|
expect(bridge.getNode(rid as any)).not.toBeNull()
|
|
}
|
|
})
|
|
|
|
test('rejects unknown template ids', async () => {
|
|
const result = await client.callTool({
|
|
name: 'create_from_template',
|
|
arguments: { id: 'not-a-template' },
|
|
})
|
|
expect(result.isError).toBe(true)
|
|
})
|
|
|
|
test('saves to the store when save: true', async () => {
|
|
const result = await client.callTool({
|
|
name: 'create_from_template',
|
|
arguments: { id: 'two-bedroom', save: true, name: 'My flat' },
|
|
})
|
|
expect(result.isError).toBeFalsy()
|
|
const parsed = parseToolText(result.content as StoredTextContent[])
|
|
expect(parsed.scene).toBeDefined()
|
|
const scene = parsed.scene as {
|
|
id: string
|
|
name: string
|
|
url: string
|
|
editorUrl: string
|
|
nodeCount: number
|
|
}
|
|
expect(scene.name).toBe('My flat')
|
|
expect(scene.url).toBe(`/editor/${scene.id}`)
|
|
expect(scene.editorUrl).toBe(`/editor/${scene.id}`)
|
|
expect(scene.nodeCount).toBeGreaterThan(0)
|
|
|
|
// Confirm the store actually holds it.
|
|
const loaded = await store.load(scene.id)
|
|
expect(loaded).not.toBeNull()
|
|
})
|
|
|
|
test('two invocations produce disjoint id sets', async () => {
|
|
const a = await client.callTool({
|
|
name: 'create_from_template',
|
|
arguments: { id: 'empty-studio' },
|
|
})
|
|
const idsA = (parseToolText(a.content as StoredTextContent[]).rootNodeIds as string[]).sort()
|
|
const b = await client.callTool({
|
|
name: 'create_from_template',
|
|
arguments: { id: 'empty-studio' },
|
|
})
|
|
const idsB = (parseToolText(b.content as StoredTextContent[]).rootNodeIds as string[]).sort()
|
|
for (const id of idsA) {
|
|
expect(idsB).not.toContain(id)
|
|
}
|
|
})
|
|
|
|
test('create_house_from_brief creates, saves, and returns an editor URL', async () => {
|
|
const result = await client.callTool({
|
|
name: 'create_house_from_brief',
|
|
arguments: {
|
|
brief: 'Create a compact modern two-bedroom home with a small patio.',
|
|
projectName: 'Brief house',
|
|
bedroomCount: 2,
|
|
landscaping: true,
|
|
},
|
|
})
|
|
expect(result.isError).toBeFalsy()
|
|
const parsed = parseToolText(result.content as StoredTextContent[])
|
|
expect(typeof parsed.projectId).toBe('string')
|
|
expect(parsed.editorUrl).toBe(`/editor/${parsed.projectId}`)
|
|
expect(parsed.version).toBe(1)
|
|
expect(parsed.published).toBe(true)
|
|
expect(parsed.nodeCount as number).toBeGreaterThan(0)
|
|
expect(parsed.nextStep as string).toContain('get_project_status')
|
|
})
|
|
})
|
|
|
|
describe('create_from_template without a store', () => {
|
|
let client: Client
|
|
let bridge: SceneBridge
|
|
|
|
beforeEach(async () => {
|
|
bridge = new SceneBridge()
|
|
bridge.setScene({}, [])
|
|
const operations = createSceneOperations({ bridge })
|
|
const server = new McpServer({ name: 'test', version: '0.0.0' })
|
|
// No store in operations → save should be gracefully skipped.
|
|
registerCreateFromTemplate(server, operations)
|
|
const [srvT, cliT] = InMemoryTransport.createLinkedPair()
|
|
client = new Client({ name: 'test-client', version: '0.0.0' })
|
|
await Promise.all([server.connect(srvT), client.connect(cliT)])
|
|
})
|
|
|
|
test('applies a template without erroring when no store is wired', async () => {
|
|
const result = await client.callTool({
|
|
name: 'create_from_template',
|
|
arguments: { id: 'garden-house' },
|
|
})
|
|
expect(result.isError).toBeFalsy()
|
|
const parsed = parseToolText(result.content as StoredTextContent[])
|
|
expect(parsed.templateId).toBe('garden-house')
|
|
})
|
|
|
|
test('save:true is a no-op but still succeeds without a store', async () => {
|
|
const result = await client.callTool({
|
|
name: 'create_from_template',
|
|
arguments: { id: 'garden-house', save: true },
|
|
})
|
|
// Does not error; no `scene` field is returned because there is no store.
|
|
expect(result.isError).toBeFalsy()
|
|
const parsed = parseToolText(result.content as StoredTextContent[])
|
|
expect(parsed.scene).toBeUndefined()
|
|
})
|
|
})
|