77442861d9
* Add roof surface placement support for items Items (e.g. solar panels) can now be placed on sloped roof surfaces. The placement system computes euler rotation from the roof surface normal so items sit flush on the slope instead of going inside. - Add roofStrategy to placement-strategies with enter/move/click/leave - Wire roof:enter/move/click/leave events in the placement coordinator - Add calculateRoofRotation in placement-math using surface normals - Support full 3D cursor rotation for sloped surfaces - Items on roofs are parented to the level with world-space rotation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fixed conflict * feat(floorplan): add construction dimension strings * feat(floorplan): coordinate opening dimensions * feat(floorplan): add opening documentation * feat(floorplan): add construction dimensions and notes * feat(floorplan): add interior dimensions and curved note leaders * feat(floorplan): improve construction dimensions and document plan * feat(floorplan): harden construction document output * feat(floorplan): add annotation collision diagnostics * feat(floorplan): size export annotations in paper space * feat(floorplan): automatically separate overlapping labels * fix(floorplan): resolve dense label overlaps * fix(floorplan): remove stale collision warning overlays * fix(floorplan): treat mark pills as collision obstacles * feat(floorplan): place short dimension values outside * fix(floorplan): preserve dimension string order * fix(floorplan): avoid architectural geometry in label layout * feat(floorplan): add dimension side fallback leaders * docs(floorplan): update chapter 17 implementation status * fix(floorplan): dimension subdivided interior walls * feat: add associative floor plan dimensions * feat: add continuous construction dimension strings * feat: add structural floor plan grids * feat: coordinate columns with structural grids Snap column placement and movement to structural axes and intersections, derive associative grid references, and preserve floor-plan rotation by allowing secondary-button pointer moves through the grid drafting layer. * feat: add architectural room documentation Add room-role metadata, editable documentation fields, centered room labels, and persisted live/PDF visibility while preserving generic zone behavior. * feat: generate architectural room schedules Add registry-driven room schedule rows with unit-aware areas and heights, natural room ordering, enclosure resolution, and document-quality warnings. * feat: add reliable room clear dimensions Derive unit-aware clear dimensions from proven modeled inside wall faces for straight rectangular rooms, including rotated and split-wall enclosures, while suppressing unproven datums. * feat: add architectural stair documentation Add level-aware UP/DN graphics, derived flight and rail notes, plan break and overhead conventions, linked destination-level projection, and persisted live/PDF visibility. * feat: add typed specialty construction notes Add schema-validated specialty payloads, standardized plan notation, contract-scope metadata, configurable overhead outlines, and editor authoring controls. * feat: add curved and circular dimensions Add associative radius, diameter, center, chord, arc-length, angular, and coordinate modes with unit-aware notation, repeated-feature labels, 2D authoring, and document controls. * feat: coordinate floor plan drawing types Add persistent floor, foundation, reflected-ceiling, roof, and site plan views with per-dimension show, omit, reference, and foundation-controller behavior across live and PDF output. * feat: add associative curved wall dimensions Bind radius, center, chord, arc-length, and angular construction dimensions directly to curved wall geometry so annotations update when the host curve changes. * fix: render automatic curved wall dimensions The wall floor-plan builder explicitly skipped curved walls, leaving the associative authoring workflow as the only dimension path. Render a concentric arc-length dimension automatically and keep it governed by automatic-dimension visibility. * fix: use radius callout for curved walls Replace the automatic arc-length annotation with the source-standard radius method: computed center mark, radial leader, curve arrow, and R value. Keep adjacent linear strings responsible for locating the curve tangencies and depth. * Implement construction dimension string editing * Add construction dimension standards controls * Apply drawing standards to automatic dimensions * Add floorplan overhead and reference visibility controls * Add view-specific dimension segment suppression * Add persistent drawing sheet model * Plot floorplan exports at fixed scale * Apply paper-space annotation profiles * Compose floorplan PDF sheets * Support sheet paper sizes and preflight * Persist pinned annotation layout overrides * Expand annotation collision obstacles * Add floorplan annotation preflight surface * Add reusable drawing sheet general notes * Add drawing sheet keyed note instances * Add drawing sheet document markers * Expand construction note leader terminators * Add wall assembly layer model * Resolve wall assembly datum references * Add wall assembly floorplan graphics * Add opening documentation dimension policies * Add finish-face room clear dimensions * Extend room clear dimensions to rectilinear rooms * Add construction module advisories * Add clearance advisory profiles * Add dimension completeness audit * Expand dimension completeness audit * Include preflight issues in completeness audit * feat: complete floorplan construction documentation * refactor: remove construction note node * feat: refine floorplan documentation and unit display * fix(editor): improve floorplan PDF dimensions * fix(floorplan): refresh annotation collision layout * fix(floorplan): keep annotations clear and restore registry boundaries * feat(floorplan): refine construction dimension references * fix(floorplan): align documentation tools with architecture --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
4.0 KiB
4.0 KiB
Comparison Target
- Source visual truth:
/var/folders/sn/2jgcj5r95qq3t4l_7tzjh2gh0000gn/T/codex-clipboard-18484c1f-bc43-43a1-a329-791cb5605ff4.pngand/var/folders/sn/2jgcj5r95qq3t4l_7tzjh2gh0000gn/T/codex-clipboard-1ff72f24-c84b-4b6a-94eb-4ced9a04bd4d.png. - Implementation screenshot:
/private/tmp/internal-dimension-lines-preview.png. - Viewport: 1280 × 720.
- State: local scene route after clicking 2D and waiting 2.5 seconds; 3D remained selected and the scene remained on its loading indicator.
- Intended state: internal dimension baselines, witness lines, ticks, and values render clear of the wall, and enclosed perimeter doors receive room-side width dimensions.
Full-view Comparison Evidence
- The source screenshots show internal values while their linework is collapsed onto the host walls, making the strings read as detached text.
- The larger left perimeter door has no room-side width dimension in the source state.
- The implementation screenshot could not be compared at the same scene state because the local scene did not finish loading.
Focused-region Comparison Evidence
- Source: the horizontal internal strings contain values such as
0.5m,0.9m,4.9m, and3.5m, but the intended parallel baseline and extension linework is not visibly separated from the wall. - Generated implementation geometry now places automatic internal baselines at
0.55 mfrom their witness origins rather than explicitly pinning them at0 m. - Generated plans now include room-side opening chains for enclosed perimeter walls in all four orientations, including a left-side door.
- A same-state rendered focused comparison is blocked by the local loading state.
Findings
- [P0] Browser-rendered implementation evidence unavailable. Location: local editor preview. Evidence: the captured implementation contains only the loading indicator; clicking 2D leaves 3D selected. Impact: final screen-space line visibility, collisions, and door-width placement cannot be visually accepted. Fix: restore a working local scene preview and recapture the reported room in 2D.
Required Fidelity Surfaces
- Fonts and typography: source labels remain unchanged by this fix; post-fix rendered typography is blocked from inspection.
- Spacing and layout rhythm: geometry tests verify the internal baseline clearance is restored to
0.55 m; pixel-level rhythm is blocked from inspection. - Colors and visual tokens: no color or token changes were made; rendered contrast is blocked from inspection.
- Image quality and asset fidelity: no image assets are involved.
- Copy and content: dimension values remain generated from the same measurements; the missing perimeter-door width is now included.
Comparison History
- Earlier P0: internal baseline coordinates were explicitly equal to witness coordinates, overriding
offsetDistanceand collapsing lines onto walls. - Fix: preserve omitted automatic baselines so the renderer applies the configured offset; add enclosed room-side opening chains for perimeter walls.
- Post-fix evidence: SVG renderer regression asserts a
0.55 mautomatic baseline, and planner regressions cover top, right, bottom, and left perimeter doors. Browser-rendered evidence remains blocked.
Implementation Evidence
- Focused dimension, wall, floor-plan, and registry tests: 61 passed, 0 failed.
- Nodes package build: passed.
- Editor package type-check: blocked by the unrelated missing
resolveFloorplanExportViewportexport referenced byfloorplan-export.test.ts. - Biome check: passed.
- Git diff whitespace check: passed.
- Browser console warnings/errors: none reported.
Implementation Checklist
- Restore the local editor preview.
- Reopen the reported room in 2D.
- Confirm each internal string has a visible parallel baseline, witness lines, and ticks.
- Confirm the large left-side door displays its room-side width dimension.
Follow-up Polish
- Reassess internal line contrast only after the corrected geometry can be seen in the target scene.
final result: blocked