morgan/editor

Fork 0

Files

T

History

7d4c8b6bd4 fix: resolve state management issues and memory leaks (#152 )

This commit fixes several issues in the core state management:

1. Fix deleteNodesAction recursive call issue
   - Previously, the function recursively called get().deleteNodes()
     inside the set() callback, which could cause state inconsistencies.
   - Now collects all descendant IDs first in a separate pass, then
     deletes them all in a single batch operation.

2. Fix memory leak in use-scene temporal tracking
   - Module-level variables (prevPastLength, prevFutureLength,
     prevNodesSnapshot) persisted across store re-creations.
   - Now cleared in unloadScene() to release stale node references.
   - Added clearTemporalTracking() helper function.

3. Remove unused variable in wall-system
   - Removed debug variable 'useFrameNb' that was declared but never used.

4. Fix requestAnimationFrame in updateNodesAction
   - Previously used RAF without cleanup, causing multiple queued
     callbacks when updates happened rapidly.
   - Now uses a single tracked RAF with cancellation support.

Co-authored-by: hobostay <hobostay@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-03-26 00:30:16 -04:00

src

fix: resolve state management issues and memory leaks (#152 )

2026-03-26 00:30:16 -04:00

package.json

feat: 2D editing — floorplan panel, measurements, command palette (v0.3.0)

2026-03-24 19:48:11 +00:00

README.md

packages

2026-02-05 08:22:19 +09:00

tsconfig.json

remove community

2026-03-13 09:07:46 +01:00

README.md

@pascal-app/core

Core library for Pascal 3D building editor.

Installation

npm install @pascal-app/core

Peer Dependencies

npm install react three @react-three/fiber @react-three/drei

What's Included

Node Schemas - Zod schemas for all building primitives (walls, slabs, items, etc.)
Scene State - Zustand store with IndexedDB persistence and undo/redo
Systems - Geometry generation for walls, floors, ceilings, roofs
Scene Registry - Fast lookup from node IDs to Three.js objects
Spatial Grid - Collision detection and placement validation
Event Bus - Typed event emitter for inter-component communication
Asset Storage - IndexedDB-based file storage for user-uploaded assets

Usage

import { useScene, WallNode, ItemNode } from '@pascal-app/core'

// Create a wall
const wall = WallNode.parse({
  points: [[0, 0], [5, 0]],
  height: 3,
  thickness: 0.2,
})

useScene.getState().createNode(wall, parentLevelId)

// Subscribe to scene changes
function MyComponent() {
  const nodes = useScene((state) => state.nodes)
  const walls = Object.values(nodes).filter(n => n.type === 'wall')

  return <div>Total walls: {walls.length}</div>
}

Node Types

SiteNode - Root container
BuildingNode - Building within a site
LevelNode - Floor level
WallNode - Vertical wall with optional openings
SlabNode - Floor slab
CeilingNode - Ceiling surface
RoofNode - Roof geometry
ZoneNode - Spatial zone/room
ItemNode - Furniture, fixtures, appliances
ScanNode - 3D scan reference
GuideNode - 2D guide image reference

Systems

Systems process dirty nodes each frame to update geometry:

WallSystem - Wall geometry with mitering and CSG cutouts
SlabSystem - Floor polygon generation
CeilingSystem - Ceiling geometry
RoofSystem - Roof generation
ItemSystem - Item positioning on walls/ceilings/floors

License

MIT