Wassim SAMADandClaude Opus 4.7
6d97a87547
Two concerns from the spike:
1) Selection / floating-action-menu had hardcoded kind lists scattered
across 4 files. Adding 'shelf' to each one per migration was the
wrong abstraction — the user's question "did you make it generic
from the noderegistry?" was the right one. Done now.
Added to @pascal-app/core/registry:
- getSelectableKinds(): string[] — returns all registered kinds
whose definition declares `capabilities.selectable`.
- isRegistrySelectable(kind): boolean — predicate for OR-chains.
Refactored hardcoded sites to merge registry kinds at runtime,
keeping legacy hardcoded lists intact so existing kinds keep
working unchanged:
- editor SelectionManager: 4 subscription loops (enter/leave/click)
+ structure.isValid + getSelectionTarget — all augment with
registry kinds. Phase 6 deletes the hardcoded lists.
- viewer SelectionManager: subscription loop + SelectableNodeType
broadened with `(string & {})` to accept registry kinds.
- floating-action-menu: ALLOWED_TYPES OR'd with isRegistrySelectable.
- Removed the manually-added 'shelf' entries from previous commit
857ddd4; they were redundant once the registry-driven path landed.
Future built-in nodes that declare `capabilities.selectable` get
click-selection + hover + the floating action menu (move/delete
icons) for free, no editing of these 4 files.
2) Spawn parity is signed off. Drop the
NEXT_PUBLIC_USE_REGISTRY_FOR_SPAWN flag entirely; spawn registers
unconditionally in builtinPlugin.nodes. Restored SPAWN_COLOR to
the original #22c55e green (was #ef4444 red as a Phase 2
verification marker).
Pre-existing typecheck errors in editor (ceiling/fence/slab tree-node,
scene.ts buildingId) are unchanged.
630 tests still pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@pascal-app/core
Core library for Pascal 3D building editor.
Installation
npm install @pascal-app/core
Peer Dependencies
npm install react three @react-three/fiber @react-three/drei
What's Included
- Node Schemas - Zod schemas for all building primitives (walls, slabs, items, etc.)
- Scene State - Zustand store with IndexedDB persistence and undo/redo
- Systems - Geometry generation for walls, floors, ceilings, roofs
- Scene Registry - Fast lookup from node IDs to Three.js objects
- Spatial Grid - Collision detection and placement validation
- Event Bus - Typed event emitter for inter-component communication
- Asset Storage - IndexedDB-based file storage for user-uploaded assets
Usage
import { useScene, WallNode, ItemNode } from '@pascal-app/core'
// Create a wall
const wall = WallNode.parse({
points: [[0, 0], [5, 0]],
height: 3,
thickness: 0.2,
})
useScene.getState().createNode(wall, parentLevelId)
// Subscribe to scene changes
function MyComponent() {
const nodes = useScene((state) => state.nodes)
const walls = Object.values(nodes).filter(n => n.type === 'wall')
return <div>Total walls: {walls.length}</div>
}
Node Types
SiteNode- Root containerBuildingNode- Building within a siteLevelNode- Floor levelWallNode- Vertical wall with optional openingsSlabNode- Floor slabCeilingNode- Ceiling surfaceRoofNode- Roof geometryZoneNode- Spatial zone/roomItemNode- Furniture, fixtures, appliancesScanNode- 3D scan referenceGuideNode- 2D guide image reference
Systems
Systems process dirty nodes each frame to update geometry:
WallSystem- Wall geometry with mitering and CSG cutoutsSlabSystem- Floor polygon generationCeilingSystem- Ceiling geometryRoofSystem- Roof generationItemSystem- Item positioning on walls/ceilings/floors
License
MIT