Aymeric RabotandClaude Fable 5
aa3b0ef758
Dual review pass (Claude multi-angle + Codex release-quality). One correctness fix and the agreed do-now cleanups: - fix: clone-scene-graph remaps roofSegmentId like wallId in both clone paths — duplicated scenes/levels kept pointing roof-hosted children at the original segments. - extract the settled, stateless roof target/cursor math shared by the four door/window tools into shared/roof-wall-opening-placement.ts (resolveRoofWallOpeningTarget + getRoofWallOpeningCursorPose + worldToSelectedBuildingLocal); tools keep the stateful lifecycle (drafts, undo/temporal, commit field lists). −199 net lines. - rename host-generic state: currentWallId→currentHostId, markWallDirty→markHostDirty (they hold segment ids too); capability cascadesViaHostSegment→dirtyHandledByOwnSystem (behavior-facing, before the public API hardens). - drop getRoofAccessoryKinds from core's public API — its only caller was the standalone Build tab, which now enumerates the registry inline with its app-specific filter. - window move-tool uses the shared stripPlacementMetadataFlags; stale "segment-local" comment fixed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@pascal-app/core
Core library for Pascal 3D building editor.
Installation
npm install @pascal-app/core
Peer Dependencies
npm install react three @react-three/fiber @react-three/drei
What's Included
- Node Schemas - Zod schemas for all building primitives (walls, slabs, items, etc.)
- Scene State - Zustand store with IndexedDB persistence and undo/redo
- Systems - Geometry generation for walls, floors, ceilings, roofs
- Scene Registry - Fast lookup from node IDs to Three.js objects
- Spatial Grid - Collision detection and placement validation
- Event Bus - Typed event emitter for inter-component communication
- Asset Storage - IndexedDB-based file storage for user-uploaded assets
Usage
import { useScene, WallNode, ItemNode } from '@pascal-app/core'
// Create a wall
const wall = WallNode.parse({
points: [[0, 0], [5, 0]],
height: 3,
thickness: 0.2,
})
useScene.getState().createNode(wall, parentLevelId)
// Subscribe to scene changes
function MyComponent() {
const nodes = useScene((state) => state.nodes)
const walls = Object.values(nodes).filter(n => n.type === 'wall')
return <div>Total walls: {walls.length}</div>
}
Node Types
SiteNode- Root containerBuildingNode- Building within a siteLevelNode- Floor levelWallNode- Vertical wall with optional openingsSlabNode- Floor slabCeilingNode- Ceiling surfaceRoofNode- Roof geometryZoneNode- Spatial zone/roomItemNode- Furniture, fixtures, appliancesScanNode- 3D scan referenceGuideNode- 2D guide image reference
Systems
Systems process dirty nodes each frame to update geometry:
WallSystem- Wall geometry with mitering and CSG cutoutsSlabSystem- Floor polygon generationCeilingSystem- Ceiling geometryRoofSystem- Roof generationItemSystem- Item positioning on walls/ceilings/floors
License
MIT