Files

T

Adrian PerezandClaude Opus 4.7 6ace4bf7c8 docs(mcp): add Phase 10 pre-push audit reports (5 agents)

Five parallel audit agents reviewed the branch before open-sourcing
the PR to pascalorg/editor:

- a1-secrets.md: SAFE TO PUSH. Scanned 176 files / 40,768 diff lines.
  Zero secrets, tokens, API keys, PEM blocks, JWTs, or cookies.
  Only MEDIUM finding: absolute /Users/adrian paths in test-report
  scripts (cosmetic, not security).

- a2-security.md: FOUND 2 HIGH-severity issues, both FIXED in
  commit 8757de0:
  * PUT /api/scenes/[id] still had the loose graphSchema that POST
    got fixed in Phase 8 P4. Shared schema extracted to
    apps/editor/lib/graph-schema.ts so both routes re-validate.
  * photo_to_scene + analyze_floorplan_image + analyze_room_photo
    all did raw fetch(url) on user-supplied URLs - a textbook SSRF
    to 169.254.169.254 cloud metadata. Added safe-fetch.ts with
    private-IP / link-local / .local-hostname denylists, manual
    redirect revalidation, size cap, timeout, env-allowlist.

- a3-code-quality.md: READY FOR REVIEW. Zero production `any`, all
  tools Zod-validated in+out, uniform error handling,
  conventional-commits. Two non-blocking follow-ups: client editor
  components (SceneLoader, SaveButton) have no tests; document
  check_collisions n^2 scaling.

- a4-performance.md: SHIP WITH NOTES. MCP dist 904 KB, Supabase
  lazy-imported (zero editor bundle impact), v0.1 hot paths
  sub-200ms. Flagged: FilesystemSceneStore.index.json O(n) per
  write (fine <1k scenes), concurrency races (documented in P8),
  client render at 5k nodes unverified.

- a5-pr-description.md: polished final PR description that
  corrected stale test counts (294 not 142), disclosed all 5
  cross-cutting surfaces, named the known failures honestly,
  split the checklist, expanded the scope to the real Phase 7
  deliverables.

Overall verdict: READY TO PUSH after the A2 fixes landed. No
blockers remain.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-19 21:00:02 +02:00

4.9 KiB

Raw Blame History

A4 — Pre-push performance review (feat/mcp-server)

Date: 2026-04-18 · Scope: git diff main..HEAD (18 commits, +38,785 LOC) · Evidence: test-reports/{t1-stdio,t2-http,phase8,villa-azul}.

Verdict

SHIP WITH NOTES. At v0.1 scale (≤ 56 nodes, ≤ 50 scenes) every path is sub-200 ms. Scaling liabilities appear above ~1k scenes or under concurrent writes — neither is the launch target.

Hot paths (measured / estimated)

Path	Time	Source
T1 stdio, 21 tools round-trip	106 ms (~5 ms/tool)	t1-stdio/REPORT.md L11
P10 full sweep, 30 tools + 3 resources + 3 prompts	152 ms	p10-full-sweep.md L15
P9 edges, 13 cases incl. 5k-node save	419 ms	p9-edges.md L5
`/scene/:id` SSR (56 nodes)	58.3 ms, 81.7 KB HTML	v6-page.md L12
`/scenes` list SSR	20.9 ms, 20.0 KB	v6-page.md L14
MCP stdio cold-start to ready	~1.0-1.5 s (Bun + SDK + core + Zod)	implied
HTTP startup + 1st session	~2 s; 2nd client rejected	t2-http REPORT.md L14

106 ms for 21 tools is reasonable — stdio RTT dominates. Slowest non-vision tool paths: validate_scene (Zod-parse every node), export_json (JSON.parse(JSON.stringify) clone), apply_patch (2-pass dry-run + apply), check_collisions (O(n²) AABB, bounded by items/level).

Scaling concerns (severity order)

Filesystem index rebuild on every mutation. save/delete/rename call collectAllMeta() → readFile every scene (filesystem-scene-store.ts L192-193, L233). At 1k scenes ≈ 200-400 ms/save; at 10k ≈ 2-4 s. Fix: incremental index patch.
.index.json drift under concurrent writes (P8 BUG 2). 3/20 scenes hidden from list_scenes after parallel burst. Correctness, not perf, but fix depends on #1.
expectedVersion race (P8 BUG 1). 5 parallel saves all claim success; only one rename wins. Need per-id mutex or O_EXCL lockfile. Supabase unaffected (server-side CAS via .eq('version', …)).
findNodes({levelId}) calls resolveLevelId per node → full ancestry walk each time. O(n × depth). ~25k walks at 5k nodes. Memoize per call.
getChildren/_collectDescendants iterate all nodes per call. O(n) each; fine today, slow at 50k.
exportJSON uses JSON.parse(JSON.stringify) (scene-bridge.ts L39-46). Replace with structuredClone for ~2× speedup.
Fixed-point serialize loop in save (L168-184) stringifies up to 5× per save to settle sizeBytes. At 2.4 MB that's 125 ms wasted.
check_collisions O(n²) — bounded by items/level; degenerate at 1k+ items.
5k-node client render is unverified. P9 saved 5k-node scene (2.4 MB) but no FPS measurement. Villa Azul 56 nodes = 120 FPS. This is the single biggest unknown for client perf.

Build-size

packages/mcp/dist/: 904 KB total (66 JS files, 210 KB code + 91 KB .d.ts + maps).
Top 5 JS: bridge/scene-bridge.js 18.2 KB · storage/filesystem-scene-store.js 13.3 KB · tools/photo-to-scene/photo-to-scene.js 12.6 KB · tools/variants/mutations.js 11.3 KB · storage/supabase-scene-store.js 10.8 KB.
Average file 3.2 KB — no bundle bloat.
@supabase/supabase-js: MCP-only (package.json L41), lazy-imported (supabase-scene-store.ts L141). Zero editor bundle impact.

Memory

SceneBridge is a singleton useScene store shared across MCP sessions. Zundo limit: 50 bounds history. 5k-node graph × 50 = ~120 MB upper bound — bounded, not leaked.
urlCache (packages/core/src/lib/asset-storage.ts L6) unbounded, browser-only; pre-existing Phase 3 flag, not regressed.
atomicWrite cleans .tmp on failure (L287); P8 observed stray .tmp=0.

Recommended follow-ups

(P1) Incremental .index.json patch on save/delete/rename (fixes concerns #1 + #2).
(P1) Per-id Promise-chain mutex in Filesystem store to close expectedVersion race (#3).
(P2) Lazy-load vision/photo-to-scene/variants tools behind first-call gate. Saves ~40 KB + ~100 ms cold-start.
(P2) Swap JSON.parse(JSON.stringify) in exportJSON → structuredClone.
(P3) Memoize levelId per node in SceneBridge. 10-50× speedup on find_nodes({levelId}).
(P3) Fix StreamableHTTP single-session; add multi-session dispatcher or clear 503.

Benchmarks to add

bench/scene-bridge.bench.ts — findNodes({levelId}) + _collectDescendants at 1k/5k/10k nodes; assert p99 < 50 ms.
bench/filesystem-store.bench.ts — save()+list() at 100/1k/10k scenes; current code will fail at 10k (concern #1).
bench/client-render.bench.ts — React profiler over applySceneGraphToEditor at 1k/5k nodes; assert first-paint < 500 ms and steady FPS ≥ 30.

Red flags

None ship-blocking. Scaling liabilities (#1-#3) well-understood. Client render at 5k nodes is the only material unknown and should be verified pre-GA, not pre-push.

Report: /Users/adrian/Desktop/editor/.worktrees/mcp-server/packages/mcp/test-reports/pre-push/a4-performance.md

4.9 KiB Raw Blame History Unescape Escape