morgan/editor
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(shelf): recess plates 1mm to stop z-fighting with the frame

Browse Source 
Open-rack / no-sides shelves span their boards across the full footprint, so a
board's end / front / back faces land exactly on the corner posts' outer faces
(and, with a back panel, on its rear face). Coplanar surfaces the depth buffer
can't order flicker as z-fighting (visible as seams where plates meet posts).

Recess every board 1mm on width + depth via a `boardGeometry` helper so each
plate sits just inside the frame — the meshes still overlap (no visible gap),
but no two faces are coplanar. Frame parts (posts/sides/back/dividers/brackets)
keep their full size as the silhouette.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Wassim SAMAD
2026-06-16 11:10:34 -04:00
co-authored by Claude Opus 4.8
parent 101341d98d
commit e17c298284
1 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/nodes/src/shelf/geometry.ts
+21 -6
View File
@@ -63,6 +63,21 @@ function stampShelfSlot(mesh: Mesh, slotId: ShelfSlotId): Mesh {
return mesh
}
// Plates (boards) span the full footprint, so their end / front / back faces
// land exactly on the frame's (posts / sides / back) outer faces — coplanar
// surfaces the depth buffer can't separate, which flickers as z-fighting. Recess
// every board 1mm on width + depth so it sits just inside the frame: the meshes
// still overlap (no visible gap), but no two faces are coplanar.
const BOARD_INSET = 0.001
function boardGeometry(width: number, thickness: number, depth: number): BoxGeometry {
return new BoxGeometry(
Math.max(width - 2 * BOARD_INSET, 0.001),
thickness,
Math.max(depth - 2 * BOARD_INSET, 0.001),
)
}
export function buildShelfGeometry(
rawNode: ShelfNode,
ctx?: GeometryContext,
@@ -113,7 +128,7 @@ export function buildShelfGeometry(
function buildWallShelf(group: Group, node: ShelfNode, materials: ShelfSlotMaterials) {
for (const y of boardCenterYs(node)) {
const board = stampShelfSlot(
new Mesh(new BoxGeometry(node.width, node.thickness, node.depth), materials.shelves),
new Mesh(boardGeometry(node.width, node.thickness, node.depth), materials.shelves),
'shelves',
)
board.name = `shelf-board-${boardRowIndex(node, y)}`
@@ -155,7 +170,7 @@ function buildBookshelf(group: Group, node: ShelfNode, materials: ShelfSlotMater
// Top + bottom + intermediate boards
for (const y of boardCenterYs(node)) {
const board = stampShelfSlot(
new Mesh(new BoxGeometry(innerWidth, node.thickness, node.depth), materials.shelves),
new Mesh(boardGeometry(innerWidth, node.thickness, node.depth), materials.shelves),
'shelves',
)
board.name = `shelf-board-${boardRowIndex(node, y)}`
@@ -165,7 +180,7 @@ function buildBookshelf(group: Group, node: ShelfNode, materials: ShelfSlotMater
if (node.withBottom) {
const bottom = stampShelfSlot(
new Mesh(new BoxGeometry(innerWidth, node.thickness, node.depth), materials.shelves),
new Mesh(boardGeometry(innerWidth, node.thickness, node.depth), materials.shelves),
'shelves',
)
bottom.name = 'shelf-board-bottom'
@@ -226,7 +241,7 @@ function buildOpenRack(group: Group, node: ShelfNode, materials: ShelfSlotMateri
for (const y of boardCenterYs(node)) {
const board = stampShelfSlot(
new Mesh(new BoxGeometry(innerWidth, boardThickness, node.depth), materials.shelves),
new Mesh(boardGeometry(innerWidth, boardThickness, node.depth), materials.shelves),
'shelves',
)
board.name = `shelf-board-${boardRowIndex(node, y)}`
@@ -264,7 +279,7 @@ function buildCubby(group: Group, node: ShelfNode, materials: ShelfSlotMaterials
for (const y of boardCenterYs(node)) {
const board = stampShelfSlot(
new Mesh(new BoxGeometry(innerWidth, node.thickness, node.depth), materials.shelves),
new Mesh(boardGeometry(innerWidth, node.thickness, node.depth), materials.shelves),
'shelves',
)
board.name = `shelf-board-${boardRowIndex(node, y)}`
@@ -274,7 +289,7 @@ function buildCubby(group: Group, node: ShelfNode, materials: ShelfSlotMaterials
if (node.withBottom) {
const bottom = stampShelfSlot(
new Mesh(new BoxGeometry(innerWidth, node.thickness, node.depth), materials.shelves),
new Mesh(boardGeometry(innerWidth, node.thickness, node.depth), materials.shelves),
'shelves',
)
bottom.name = 'shelf-board-bottom'