Phase 5 Stage D: revert curve + whole-item move affordances to legacy

User-reported regressions made it clear that my D-ports of the curve
and whole-item move tools introduced more friction than they removed.
The legacy CurveFenceTool / CurveWallTool / MoveFenceTool /
MoveSlabTool / MoveCeilingTool ship more polish than the new ports do
right now:

  - Legacy curve tools pre-snap the pointer position to the 0.5m grid
    BEFORE projecting onto the chord normal, and they Shift-toggle to
    a free-place mode. The ports skipped both — finer math, but the
    user-visible UX regressed (laggy because the cascade resolver fires
    per move, history feels broken near the no-op threshold).
  - Legacy whole-item moves use scene.update per tick which keeps
    hosted children visually aligned. The live-drag mesh.position port
    cleared the offset before the GeometrySystem could rebuild,
    producing a one-frame teleport on commit.

Drop the affordance registrations for those tools — the ToolManager /
MoveTool dispatch falls back to the legacy per-kind tools when the
registry doesn't declare the affordance. Stage D progress preserved
for: fence move-endpoint (linked cascade + alt-detach), slab/ceiling
boundary + hole editors, fence placement, slab placement, ceiling
placement.

The kind-owned files (curve-tool.tsx, move-tool.tsx, actions/curve.ts,
actions/move.ts) stay on disk for the next iteration — when they
reach parity with legacy UX, re-add the affordance entries.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Wassim SAMAD
2026-05-18 08:42:40 -04:00
co-authored by Claude Opus 4.7
parent d1231b4901
commit da63081f73
4 changed files with 25 additions and 33 deletions
+6 -4
View File
@@ -58,13 +58,15 @@ export const slabDefinition: NodeDefinition<typeof SlabNode> = {
// with axis/45° snap (Shift to defeat).
tool: () => import('./tool'),
// Stage D: drag/edit affordances. Boundary editor + hole editor
// delegate to the shared `<PolygonEditor>`; move uses the single-
// undo dance for the polygon-translate commit.
// Stage D — boundary + hole editors ported (thin <PolygonEditor>
// wrappers, behaviorally identical to legacy). Whole-slab move kept
// on the legacy MoveSlabTool: the live-drag mesh.position port
// introduced a one-frame teleport on commit (geometry rebuild lags
// the position clear), and the legacy already has acceptable perf
// via RAF-batched markDirty.
affordanceTools: {
'boundary-edit': () => import('./boundary-editor'),
'hole-edit': () => import('./hole-editor'),
move: () => import('./move-tool'),
},
// Stage B: pure geometry function.