fix(viewer): UI flicker on camera move from interactive overlays + dirty-mark leaks (#401)

* chore: sync bun.lock with 0.9.1 workspace versions

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(viewer): stop interactive overlays from starving frames and flickering the UI

Every interactive item mounted a drei <Html occlude> overlay
unconditionally — invisible (opacity 0) when no zone was selected, but
still alive. With `occlude` as a bare boolean, drei raycasts the entire
scene per overlay on every camera-move frame, and rewrites each
element's z-index while toggling display when the occlusion flips. On
scenes with hundreds of interactive items (recessed lights, ceiling
fans) this starved the frame budget and made the whole DOM UI blink
during camera moves while the WebGPU canvas stayed healthy.

Overlays now mount only while a zone is selected and the item sits
inside its polygon, fade in/out over 300ms (the child components stay
rendered so the exit transition can play before the <Html> unmounts),
and drop `occlude` entirely. eps=-1 works around a drei mount bug: its
mount path writes the element transform without the distanceFactor
scale, and with a static camera the eps guard never re-applies it, so
freshly mounted overlays stayed mis-scaled until the camera moved.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(viewer): break down dirty nodes by kind in the perf overlay

DIRTY now reads e.g. "29 (12 wall, 9 ceiling, 8 item)" — sorted by
count, only non-zero kinds, with a "missing" bucket for dirty ids whose
node no longer exists. Makes dirty-mark leaks attributable at a glance.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* perf(core): skip dirty marks for kinds with no dirty consumer

dirtyNodes is consumed by GeometrySystem (def.geometry),
FloorElevationSystem (capabilities.floorPlaced), and the legacy
per-kind viewer systems. Site, building, level, zone, and guide match
none of those, so their marks were never cleared: they accumulated for
the whole session (every child create/delete dirties its parent),
permanently defeated every consumer's empty-set early exit each frame,
and polluted the perf overlay's DIRTY readout.

NodeDefinition gains an explicit dirtyTracking?: boolean opt-out
(default tracked — no derivable predicate exists since wall's dirty
consumption lives in the viewer while zone/guide/level declare
def.system for unrelated per-frame work). markDirty consults the
registry; the five structural kinds opt out.

Also fixes a second leak: deleteNodesAction never removed deleted ids
from the dirty set, and every consumer skips missing nodes without
clearing them, so marks on deleted nodes lived forever.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* style: replace concise-arrow forEach with for...of in deleteNodesAction

biome's useIterableCallbackReturn rejects forEach callbacks that
implicitly return a value (Set.add / clearDirty).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

This commit is contained in:

Wassim SAMAD

2026-06-12 10:05:06 -04:00

committed by

GitHub

co-authored by

Claude Fable 5

parent 5411f5abc8

commit cf24b62c44

13 changed files with 205 additions and 38 deletions

									
										packages/core/src/registry/types.ts
									
		+12
		
												View File
												
				@@ -658,6 +658,18 @@ export type NodeDefinition<S extends ZodObject<any>> = {

				  relations?: Relations

				  parametrics?: ParametricDescriptor<z.infer<S>>

				  /**

				   * Whether scene mutations add this kind to `dirtyNodes` (the per-frame

				   * rebuild queue). Default true. Set `false` for structural/organizational

				   * kinds (site, building, level, zone, guide) that no dirty consumer ever

				   * rebuilds — no `def.geometry`, no legacy viewer system, no

				   * `capabilities.floorPlaced`. Their marks are never cleared, so they

				   * accumulate for the whole session, defeat every consumer's empty-set

				   * early exit each frame, and pollute the perf overlay's DIRTY readout.

				   * If a kind later gains a dirty consumer, delete the flag.

				   */

				  dirtyTracking?: boolean

				  /**

				   * Renderer for this kind. Optional under the three-checkbox composition

				   * model (see `wiki/architecture/node-definitions.md`): when omitted, the