feat: curved wall and fixes (#236)

* feat: add polygon movement support to editor and implement dedicated move tools for walls, slabs, and ceilings

* feat: add uv2 attribute to ceiling and slab geometries for lightmap support

* Fix curved wall miters and align roof position sliders

* Fix wall measurement label and extension anchors

* Fix WebGPU renderer initialization order

* fix(editor): scope wall movement to the selected level

---------

Co-authored-by: Pascal <open@pascal.app>
This commit is contained in:
Sudhir Yadav
2026-04-15 12:41:16 -04:00
committed by GitHub
co-authored by Pascal
parent 57df224948
commit b1709de44a
37 changed files with 2307 additions and 188 deletions
+15
View File
@@ -69,9 +69,24 @@ export {
getWallPlanFootprint,
getWallThickness,
} from './systems/wall/wall-footprint'
export {
getClampedWallCurveOffset,
getMaxWallCurveOffset,
getWallChordFrame,
getWallCurveFrameAt,
getWallCurveLength,
getWallMidpointHandlePoint,
getWallStraightSnapOffset,
getWallSurfacePolygon,
isCurvedWall,
normalizeWallCurveOffset,
sampleWallCenterline,
} from './systems/wall/wall-curve'
export {
calculateLevelMiters,
getWallMiterBoundaryPoints,
type Point2D,
type WallMiterBoundaryPoints,
pointToKey,
type WallMiterData,
} from './systems/wall/wall-mitering'
+2
View File
@@ -15,6 +15,7 @@ export const WallNode = BaseNode.extend({
materialPreset: z.string().optional(),
thickness: z.number().optional(),
height: z.number().optional(),
curveOffset: z.number().optional(),
// e.g., start/end points for path
start: z.tuple([z.number(), z.number()]),
end: z.tuple([z.number(), z.number()]),
@@ -26,6 +27,7 @@ export const WallNode = BaseNode.extend({
Wall node - used to represent a wall in the building
- thickness: thickness in meters
- height: height in meters
- curveOffset: midpoint sagitta offset used to bend the wall into an arc
- start: start point of the wall in level coordinate system
- end: end point of the wall in level coordinate system
- size: size of the wall in grid units
@@ -4,6 +4,13 @@ import { sceneRegistry } from '../../hooks/scene-registry/scene-registry'
import type { AnyNodeId, CeilingNode } from '../../schema'
import useScene from '../../store/use-scene'
function ensureUv2Attribute(geometry: THREE.BufferGeometry) {
const uv = geometry.getAttribute('uv')
if (!uv) return
geometry.setAttribute('uv2', new THREE.Float32BufferAttribute(Array.from(uv.array), 2))
}
// ============================================================================
// CEILING SYSTEM
// ============================================================================
@@ -100,6 +107,7 @@ export function generateCeilingGeometry(ceilingNode: CeilingNode): THREE.BufferG
// Rotate so the shape lies flat in X-Z plane
geometry.rotateX(-Math.PI / 2)
geometry.computeVertexNormals()
ensureUv2Attribute(geometry)
return geometry
}
+46 -6
View File
@@ -4,6 +4,13 @@ import { sceneRegistry } from '../../hooks/scene-registry/scene-registry'
import type { AnyNodeId, SlabNode } from '../../schema'
import useScene from '../../store/use-scene'
function ensureUv2Attribute(geometry: THREE.BufferGeometry) {
const uv = geometry.getAttribute('uv')
if (!uv) return
geometry.setAttribute('uv2', new THREE.Float32BufferAttribute(Array.from(uv.array), 2))
}
// ============================================================================
// SLAB SYSTEM
// ============================================================================
@@ -39,6 +46,7 @@ export const SlabSystem = () => {
*/
function updateSlabGeometry(node: SlabNode, mesh: THREE.Mesh) {
const newGeo = generateSlabGeometry(node)
ensureUv2Attribute(newGeo)
mesh.geometry.dispose()
mesh.geometry = newGeo
@@ -157,16 +165,46 @@ function generatePoolGeometry(slabNode: SlabNode): THREE.BufferGeometry {
if (polygon.length < 3) return new THREE.BufferGeometry()
const positions: number[] = []
const uvs: number[] = []
const indices: number[] = []
const n = polygon.length
const bounds = new THREE.Box2()
for (const [x, z] of polygon) {
bounds.expandByPoint(new THREE.Vector2(x, z))
}
for (const hole of slabNode.holes ?? []) {
for (const [x, z] of hole) {
bounds.expandByPoint(new THREE.Vector2(x, z))
}
}
const floorWidth = Math.max(bounds.max.x - bounds.min.x, 0.001)
const floorHeight = Math.max(bounds.max.y - bounds.min.y, 0.001)
const pushFloorVertex = (x: number, y: number, z: number) => {
positions.push(x, y, z)
uvs.push((x - bounds.min.x) / floorWidth, (z - bounds.min.y) / floorHeight)
}
const pushWallVertex = (
x: number,
y: number,
z: number,
u: number,
v: number,
) => {
positions.push(x, y, z)
uvs.push(u, v)
}
// --- Floor at Y=0 ---
for (const [x, z] of polygon) positions.push(x!, 0, z!)
for (const [x, z] of polygon) pushFloorVertex(x!, 0, z!)
const pts2d = polygon.map(([x, z]) => new THREE.Vector2(x!, z!))
const holesPts2d = (slabNode.holes ?? []).map((h) => h.map(([x, z]) => new THREE.Vector2(x!, z!)))
for (const hole of slabNode.holes ?? []) {
for (const [x, z] of hole) positions.push(x!, 0, z!)
for (const [x, z] of hole) pushFloorVertex(x!, 0, z!)
}
const floorTris = THREE.ShapeUtils.triangulateShape(pts2d, holesPts2d)
@@ -182,11 +220,12 @@ function generatePoolGeometry(slabNode: SlabNode): THREE.BufferGeometry {
const [x0, z0] = polygon[i]!
const [x1, z1] = polygon[j]!
const vBase = positions.length / 3
const segmentLength = Math.max(Math.hypot(x1 - x0, z1 - z0), 0.001)
positions.push(x0!, 0, z0!) // v0 — floor level
positions.push(x1!, 0, z1!) // v1 — floor level
positions.push(x1!, depth, z1!) // v2 — ground level
positions.push(x0!, depth, z0!) // v3 — ground level
pushWallVertex(x0!, 0, z0!, 0, 0) // v0 — floor level
pushWallVertex(x1!, 0, z1!, segmentLength, 0) // v1 — floor level
pushWallVertex(x1!, depth, z1!, segmentLength, depth) // v2 — ground level
pushWallVertex(x0!, depth, z0!, 0, depth) // v3 — ground level
indices.push(vBase, vBase + 1, vBase + 2)
indices.push(vBase, vBase + 2, vBase + 3)
@@ -194,6 +233,7 @@ function generatePoolGeometry(slabNode: SlabNode): THREE.BufferGeometry {
const geo = new THREE.BufferGeometry()
geo.setAttribute('position', new THREE.Float32BufferAttribute(positions, 3))
geo.setAttribute('uv', new THREE.Float32BufferAttribute(uvs, 2))
geo.setIndex(indices)
geo.computeVertexNormals()
return geo
@@ -0,0 +1,230 @@
import type { Point2D } from './wall-mitering'
import type { WallNode } from '../../schema'
const CURVE_EPSILON = 1e-6
const DEFAULT_SAMPLE_SEGMENTS = 24
type WallCurveLike = Pick<WallNode, 'start' | 'end' | 'curveOffset'>
type CurveFrame = {
point: Point2D
tangent: Point2D
normal: Point2D
}
type WallSurfaceMiterOverrides = {
startLeft?: Point2D
startRight?: Point2D
endLeft?: Point2D
endRight?: Point2D
}
function clamp01(value: number) {
return Math.max(0, Math.min(1, value))
}
function lerp(a: number, b: number, t: number) {
return a + (b - a) * t
}
function distance(a: Point2D, b: Point2D) {
return Math.hypot(b.x - a.x, b.y - a.y)
}
export function getWallStartPoint(wall: WallCurveLike): Point2D {
return { x: wall.start[0], y: wall.start[1] }
}
export function getWallEndPoint(wall: WallCurveLike): Point2D {
return { x: wall.end[0], y: wall.end[1] }
}
export function getWallChordLength(wall: WallCurveLike) {
return distance(getWallStartPoint(wall), getWallEndPoint(wall))
}
export function getMaxWallCurveOffset(wall: WallCurveLike) {
return getWallChordLength(wall) / 2
}
export function getWallStraightSnapOffset(wall: WallCurveLike) {
return Math.min(0.03, Math.max(0.005, getWallChordLength(wall) * 0.005))
}
function clampCurveOffset(wall: WallCurveLike, offset: number) {
const maxOffset = getMaxWallCurveOffset(wall)
if (!Number.isFinite(maxOffset) || maxOffset < CURVE_EPSILON) {
return 0
}
return Math.max(-maxOffset, Math.min(maxOffset, offset))
}
export function normalizeWallCurveOffset(wall: WallCurveLike, offset: number) {
const clamped = clampCurveOffset(wall, offset)
return Math.abs(clamped) <= getWallStraightSnapOffset(wall) ? 0 : clamped
}
export function getClampedWallCurveOffset(wall: WallCurveLike) {
const value = wall.curveOffset ?? 0
const normalized = normalizeWallCurveOffset(wall, value)
return Math.abs(normalized) > CURVE_EPSILON ? normalized : 0
}
export function isCurvedWall(wall: WallCurveLike) {
return Math.abs(getClampedWallCurveOffset(wall)) > CURVE_EPSILON
}
export function getWallChordFrame(wall: WallCurveLike) {
const start = getWallStartPoint(wall)
const end = getWallEndPoint(wall)
const dx = end.x - start.x
const dy = end.y - start.y
const length = Math.hypot(dx, dy)
if (length < CURVE_EPSILON) {
return {
start,
end,
midpoint: start,
tangent: { x: 1, y: 0 },
normal: { x: 0, y: 1 },
length: 0,
}
}
return {
start,
end,
midpoint: {
x: (start.x + end.x) / 2,
y: (start.y + end.y) / 2,
},
tangent: { x: dx / length, y: dy / length },
normal: { x: -dy / length, y: dx / length },
length,
}
}
function getWallArcData(wall: WallCurveLike) {
const chord = getWallChordFrame(wall)
const sagitta = getClampedWallCurveOffset(wall)
if (Math.abs(sagitta) <= CURVE_EPSILON || chord.length < CURVE_EPSILON) {
return null
}
const absSagitta = Math.abs(sagitta)
const radius = chord.length * chord.length / (8 * absSagitta) + absSagitta / 2
const centerOffset = radius - absSagitta
const direction = Math.sign(sagitta) || 1
const center = {
x: chord.midpoint.x + chord.normal.x * centerOffset * direction,
y: chord.midpoint.y + chord.normal.y * centerOffset * direction,
}
const startAngle = Math.atan2(chord.start.y - center.y, chord.start.x - center.x)
const endAngle = Math.atan2(chord.end.y - center.y, chord.end.x - center.x)
let delta = endAngle - startAngle
if (direction > 0) {
while (delta <= 0) delta += Math.PI * 2
} else {
while (delta >= 0) delta -= Math.PI * 2
}
return { center, radius, startAngle, delta, direction }
}
export function getWallCurveFrameAt(wall: WallCurveLike, t: number): CurveFrame {
const chord = getWallChordFrame(wall)
if (!isCurvedWall(wall) || chord.length < CURVE_EPSILON) {
return {
point: {
x: lerp(chord.start.x, chord.end.x, clamp01(t)),
y: lerp(chord.start.y, chord.end.y, clamp01(t)),
},
tangent: chord.tangent,
normal: chord.normal,
}
}
const arc = getWallArcData(wall)
if (!arc) {
return {
point: chord.midpoint,
tangent: chord.tangent,
normal: chord.normal,
}
}
const angle = arc.startAngle + arc.delta * clamp01(t)
const point = {
x: arc.center.x + Math.cos(angle) * arc.radius,
y: arc.center.y + Math.sin(angle) * arc.radius,
}
const tangent =
arc.direction > 0
? { x: -Math.sin(angle), y: Math.cos(angle) }
: { x: Math.sin(angle), y: -Math.cos(angle) }
return {
point,
tangent,
normal: {
x: -tangent.y,
y: tangent.x,
},
}
}
export function getWallMidpointHandlePoint(wall: WallCurveLike) {
return getWallCurveFrameAt(wall, 0.5).point
}
export function sampleWallCenterline(wall: WallCurveLike, segments = DEFAULT_SAMPLE_SEGMENTS) {
const count = Math.max(1, segments)
return Array.from({ length: count + 1 }, (_, index) => getWallCurveFrameAt(wall, index / count).point)
}
export function getWallCurveLength(wall: WallCurveLike, segments = DEFAULT_SAMPLE_SEGMENTS) {
const points = sampleWallCenterline(wall, segments)
let totalLength = 0
for (let index = 1; index < points.length; index += 1) {
totalLength += distance(points[index - 1]!, points[index]!)
}
return totalLength
}
export function getWallSurfacePolygon(
wall: Pick<WallNode, 'start' | 'end' | 'curveOffset' | 'thickness'>,
segments = DEFAULT_SAMPLE_SEGMENTS,
miterOverrides?: WallSurfaceMiterOverrides,
) {
const halfThickness = (wall.thickness ?? 0.1) / 2
const count = Math.max(1, segments)
const left: Point2D[] = []
const right: Point2D[] = []
for (let index = 0; index <= count; index += 1) {
const frame = getWallCurveFrameAt(wall, index / count)
left.push({
x: frame.point.x + frame.normal.x * halfThickness,
y: frame.point.y + frame.normal.y * halfThickness,
})
right.push({
x: frame.point.x - frame.normal.x * halfThickness,
y: frame.point.y - frame.normal.y * halfThickness,
})
}
if (left.length > 0 && right.length > 0) {
left[0] = miterOverrides?.startLeft ?? left[0]!
right[0] = miterOverrides?.startRight ?? right[0]!
left[left.length - 1] = miterOverrides?.endLeft ?? left[left.length - 1]!
right[right.length - 1] = miterOverrides?.endRight ?? right[right.length - 1]!
}
return [...right, ...left.reverse()]
}
@@ -1,8 +1,15 @@
import type { WallNode } from '../../schema'
import { type Point2D, pointToKey, type WallMiterData } from './wall-mitering'
import { getWallSurfacePolygon, isCurvedWall } from './wall-curve'
import {
getWallMiterBoundaryPoints,
type Point2D,
pointToKey,
type WallMiterData,
} from './wall-mitering'
export const DEFAULT_WALL_THICKNESS = 0.1
export const DEFAULT_WALL_HEIGHT = 2.5
const CURVED_WALL_SURFACE_SEGMENTS = 24
export function getWallThickness(wallNode: WallNode): number {
return wallNode.thickness ?? DEFAULT_WALL_THICKNESS
@@ -10,25 +17,38 @@ export function getWallThickness(wallNode: WallNode): number {
export function getWallPlanFootprint(wallNode: WallNode, miterData: WallMiterData): Point2D[] {
const { junctionData } = miterData
const wallStart: Point2D = { x: wallNode.start[0], y: wallNode.start[1] }
const wallEnd: Point2D = { x: wallNode.end[0], y: wallNode.end[1] }
const thickness = getWallThickness(wallNode)
const halfT = thickness / 2
const v = { x: wallEnd.x - wallStart.x, y: wallEnd.y - wallStart.y }
const L = Math.sqrt(v.x * v.x + v.y * v.y)
if (L < 1e-9) {
return []
}
const nUnit = { x: -v.y / L, y: v.x / L }
const keyStart = pointToKey(wallStart)
const keyEnd = pointToKey(wallEnd)
const startJunction = junctionData.get(keyStart)?.get(wallNode.id)
const endJunction = junctionData.get(keyEnd)?.get(wallNode.id)
if (isCurvedWall(wallNode)) {
const boundaryPoints = getWallMiterBoundaryPoints(wallNode, miterData)
if (!boundaryPoints) {
return []
}
const { startLeft, startRight, endLeft, endRight } = boundaryPoints
return getWallSurfacePolygon(wallNode, CURVED_WALL_SURFACE_SEGMENTS, {
endLeft,
endRight,
startLeft,
startRight,
})
}
const pStartLeft: Point2D = startJunction?.left || {
x: wallStart.x + nUnit.x * halfT,
y: wallStart.y + nUnit.y * halfT,
@@ -37,8 +57,6 @@ export function getWallPlanFootprint(wallNode: WallNode, miterData: WallMiterDat
x: wallStart.x - nUnit.x * halfT,
y: wallStart.y - nUnit.y * halfT,
}
// Junction offsets are stored relative to the outgoing direction.
const pEndLeft: Point2D = endJunction?.right || {
x: wallEnd.x + nUnit.x * halfT,
y: wallEnd.y + nUnit.y * halfT,
+104 -4
View File
@@ -1,4 +1,5 @@
import type { WallNode } from '../../schema'
import { getWallCurveFrameAt, isCurvedWall } from './wall-curve'
// ============================================================================
// TYPES
@@ -9,6 +10,13 @@ export interface Point2D {
y: number
}
export interface WallMiterBoundaryPoints {
startLeft: Point2D
startRight: Point2D
endLeft: Point2D
endRight: Point2D
}
interface LineEquation {
a: number
b: number
@@ -127,6 +135,70 @@ function findJunctions(walls: WallNode[]): Map<string, Junction> {
return actualJunctions
}
function getWallDirectionFromJunction(
wall: WallNode,
endType: 'start' | 'end' | 'passthrough',
) {
if (endType === 'passthrough') {
return {
x: wall.end[0] - wall.start[0],
y: wall.end[1] - wall.start[1],
}
}
if (isCurvedWall(wall)) {
const frame = getWallCurveFrameAt(wall, endType === 'start' ? 0 : 1)
return endType === 'start'
? frame.tangent
: { x: -frame.tangent.x, y: -frame.tangent.y }
}
return endType === 'start'
? { x: wall.end[0] - wall.start[0], y: wall.end[1] - wall.start[1] }
: { x: wall.start[0] - wall.end[0], y: wall.start[1] - wall.end[1] }
}
function getWallBoundaryFrame(
wall: WallNode,
endType: 'start' | 'end',
) {
if (isCurvedWall(wall)) {
const frame = getWallCurveFrameAt(wall, endType === 'start' ? 0 : 1)
return {
point: frame.point,
tangent:
endType === 'start'
? frame.tangent
: { x: -frame.tangent.x, y: -frame.tangent.y },
normal: frame.normal,
}
}
const point =
endType === 'start'
? { x: wall.start[0], y: wall.start[1] }
: { x: wall.end[0], y: wall.end[1] }
const vector =
endType === 'start'
? { x: wall.end[0] - wall.start[0], y: wall.end[1] - wall.start[1] }
: { x: wall.start[0] - wall.end[0], y: wall.start[1] - wall.end[1] }
const length = Math.hypot(vector.x, vector.y)
if (length < 1e-9) {
return {
point,
tangent: { x: 1, y: 0 },
normal: { x: 0, y: 1 },
}
}
return {
point,
tangent: { x: vector.x / length, y: vector.y / length },
normal: { x: -vector.y / length, y: vector.x / length },
}
}
// ============================================================================
// MITER CALCULATION (exactly like demo)
// ============================================================================
@@ -171,10 +243,7 @@ function calculateJunctionIntersections(
}
} else {
// Normal wall endpoint (start or end)
const v =
endType === 'start'
? { x: wall.end[0] - wall.start[0], y: wall.end[1] - wall.start[1] }
: { x: wall.start[0] - wall.end[0], y: wall.start[1] - wall.end[1] }
const v = getWallDirectionFromJunction(wall, endType)
const L = Math.sqrt(v.x * v.x + v.y * v.y)
if (L < 1e-9) continue
@@ -264,6 +333,37 @@ export function calculateLevelMiters(walls: WallNode[]): WallMiterData {
return { junctionData, junctions }
}
export function getWallMiterBoundaryPoints(
wall: WallNode,
miterData: WallMiterData,
): WallMiterBoundaryPoints | null {
const thickness = wall.thickness ?? 0.1
const halfThickness = thickness / 2
const startFrame = getWallBoundaryFrame(wall, 'start')
const endFrame = getWallBoundaryFrame(wall, 'end')
const startJunction = miterData.junctionData.get(pointToKey(startFrame.point))?.get(wall.id)
const endJunction = miterData.junctionData.get(pointToKey(endFrame.point))?.get(wall.id)
return {
startLeft: startJunction?.left ?? {
x: startFrame.point.x + startFrame.normal.x * halfThickness,
y: startFrame.point.y + startFrame.normal.y * halfThickness,
},
startRight: startJunction?.right ?? {
x: startFrame.point.x - startFrame.normal.x * halfThickness,
y: startFrame.point.y - startFrame.normal.y * halfThickness,
},
endLeft: endJunction?.right ?? {
x: endFrame.point.x + endFrame.normal.x * halfThickness,
y: endFrame.point.y + endFrame.normal.y * halfThickness,
},
endRight: endJunction?.left ?? {
x: endFrame.point.x - endFrame.normal.x * halfThickness,
y: endFrame.point.y - endFrame.normal.y * halfThickness,
},
}
}
/**
* Gets wall IDs that share junctions with the given walls
*/
+61 -1
View File
@@ -8,15 +8,19 @@ import { resolveLevelId } from '../../hooks/spatial-grid/spatial-grid-sync'
import type { AnyNode, AnyNodeId, WallNode } from '../../schema'
import useScene from '../../store/use-scene'
import { DEFAULT_WALL_HEIGHT, getWallPlanFootprint, getWallThickness } from './wall-footprint'
import { getWallCurveFrameAt, getWallSurfacePolygon, isCurvedWall } from './wall-curve'
import {
calculateLevelMiters,
getAdjacentWallIds,
getWallMiterBoundaryPoints,
type Point2D,
type WallMiterData,
pointToKey,
} from './wall-mitering'
// Reusable CSG evaluator for better performance
const csgEvaluator = new Evaluator()
const CURVED_WALL_3D_ENDPOINT_INSET = 0.0015
function ensureUv2Attribute(geometry: THREE.BufferGeometry) {
const uv = geometry.getAttribute('uv')
@@ -25,6 +29,55 @@ function ensureUv2Attribute(geometry: THREE.BufferGeometry) {
geometry.setAttribute('uv2', new THREE.Float32BufferAttribute(Array.from(uv.array), 2))
}
function insetCurvedWallBoundaryPointsFor3D(
wall: WallNode,
boundaryPoints: ReturnType<typeof getWallMiterBoundaryPoints>,
miterData: WallMiterData,
) {
if (!boundaryPoints || !isCurvedWall(wall)) {
return boundaryPoints
}
const insetDistance = Math.min(
CURVED_WALL_3D_ENDPOINT_INSET,
Math.max((wall.thickness ?? 0.1) * 0.01, 0.0005),
)
if (insetDistance <= 0) {
return boundaryPoints
}
const next = { ...boundaryPoints }
const startJunction = miterData.junctions.get(pointToKey({ x: wall.start[0], y: wall.start[1] }))
const endJunction = miterData.junctions.get(pointToKey({ x: wall.end[0], y: wall.end[1] }))
if (startJunction && startJunction.connectedWalls.length > 1) {
const frame = getWallCurveFrameAt(wall, 0)
next.startLeft = {
x: next.startLeft.x + frame.tangent.x * insetDistance,
y: next.startLeft.y + frame.tangent.y * insetDistance,
}
next.startRight = {
x: next.startRight.x + frame.tangent.x * insetDistance,
y: next.startRight.y + frame.tangent.y * insetDistance,
}
}
if (endJunction && endJunction.connectedWalls.length > 1) {
const frame = getWallCurveFrameAt(wall, 1)
next.endLeft = {
x: next.endLeft.x - frame.tangent.x * insetDistance,
y: next.endLeft.y - frame.tangent.y * insetDistance,
}
next.endRight = {
x: next.endRight.x - frame.tangent.x * insetDistance,
y: next.endRight.y - frame.tangent.y * insetDistance,
}
}
return next
}
// ============================================================================
// WALL SYSTEM
// ============================================================================
@@ -170,7 +223,14 @@ export function generateExtrudedWall(
if (L < 1e-9) {
return new THREE.BufferGeometry()
}
const polyPoints = getWallPlanFootprint(wallNode, miterData)
const boundaryPoints = getWallMiterBoundaryPoints(wallNode, miterData)
const polyPoints = isCurvedWall(wallNode)
? getWallSurfacePolygon(
wallNode,
24,
insetCurvedWallBoundaryPointsFor3D(wallNode, boundaryPoints, miterData) ?? undefined,
)
: getWallPlanFootprint(wallNode, miterData)
if (polyPoints.length < 3) {
return new THREE.BufferGeometry()
}