From ae87ca5475cb18809eb3b43a00422a2b08001860 Mon Sep 17 00:00:00 2001 From: Aymeric Rabot Date: Fri, 17 Jul 2026 19:01:01 +0200 Subject: [PATCH] feat: add production measurement tools (#505) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * feat: add persistent measurement tools * feat: make measurements associative * fix: finish measurements with Escape * feat: improve measurement snapping guides * feat: clarify measurement axis feedback * feat: smart measure lens, zone reports, and direct measurement editing - Smart measurement lens: registry-owned wall/slab/zone hover reports with a single top-center HUD, click-to-pin, latest-event back pressure, and no scene writes - Conservative derived zone quantities (footprint, perimeter, proven enclosure, gross wall/floor surface, flat-room volume) with the selected-zone blueprint panel - Direct editing of committed measurements via selected-only 2D/3D vertex affordances with midpoint insertion, cancellation, and one-write history - Shared measurement surface-query session; 2D tracing joins the slab/ceiling magnetic pipeline with registered-corner snapping - Angle arcs on the smaller angle, indigo active/black resting hierarchy, screen-sized normal-aligned contact rings Co-Authored-By: Claude Fable 5 * fix: make measurement snapping always magnetic Measurement drafting and committed-edit paths gated wall, semantic, and axis magnetism on isMagneticSnapActive(), which is only true in the 'lines' snapping mode — in the default 'grid' mode corners and wall intersections barely attracted (3D association fell to the 0.012 m verify tolerance, 2D wall radii to the 0.05 m connect stick). Measurement is an analysis tool whose anchors exist to bind real geometry, so its snapping no longer consults the construction snapping-mode chip: 2D/3D drafting and committed vertex edits are always magnetic, Alt is the temporary bypass in both views (releasing the axis pull, wall magnetism, and the 2D projected-geometry pull, and shrinking association to contact tolerance). A discrete 2D wall snap (endpoint / midpoint / crossing) now outranks the locked axis pull, and committed 2D edits route the fallback through the raw pointer so free drags no longer quantize to the construction grid. Volume extrusion height keeps its mode-driven grid quantize. Codex adversarial review confirmed the diagnosis and plumbing; its 2D Alt-depth and grid-quantize findings are applied. New surface-plan-snap tests pin the magnetic override seam. Co-Authored-By: Claude Fable 5 * fix(measurement): stabilize area surface intent --------- Co-authored-by: Claude Fable 5 --- apps/editor/app/client-bootstrap.tsx | 15 +- apps/editor/app/globals.css | 1 + apps/editor/app/layout.tsx | 12 +- apps/editor/components/viewer-toolbar.tsx | 14 + packages/core/src/events/bus.ts | 3 + .../scene-registry/scene-registry.test.ts | 33 + .../hooks/scene-registry/scene-registry.ts | 31 +- packages/core/src/index.ts | 26 + .../core/src/lib/measurement-geometry.test.ts | 137 ++ packages/core/src/lib/measurement-geometry.ts | 297 +++ packages/core/src/lib/space-detection.test.ts | 72 +- packages/core/src/lib/space-detection.ts | 121 +- packages/core/src/lib/zone-quantities.test.ts | 95 + packages/core/src/lib/zone-quantities.ts | 254 ++ packages/core/src/registry/index.ts | 8 + packages/core/src/registry/subtree.test.ts | 34 + packages/core/src/registry/subtree.ts | 5 + packages/core/src/registry/types.ts | 95 +- packages/core/src/schema/index.ts | 14 + packages/core/src/schema/nodes/level.ts | 2 + .../core/src/schema/nodes/measurement.test.ts | 182 ++ packages/core/src/schema/nodes/measurement.ts | 124 + packages/core/src/schema/nodes/zone.ts | 6 + packages/core/src/schema/types.ts | 2 + .../use-scene-measurement-roundtrip.test.ts | 122 + packages/core/src/utils/clone-scene-graph.ts | 9 + .../floorplan-measurement-tool-layer.test.ts | 113 + .../floorplan-measurement-tool-layer.tsx | 1656 +++++++++++++ .../floorplan-quick-measure-layer.tsx | 212 ++ .../floorplan-registry-action-menu.tsx | 3 +- .../renderers/floorplan-label-angle.test.ts | 15 + .../renderers/floorplan-label-angle.ts | 14 + .../floorplan-registry-layer.test.ts | 160 +- .../renderers/floorplan-registry-layer.tsx | 319 ++- .../editor/floating-action-menu.tsx | 3 +- .../src/components/editor/floorplan-panel.tsx | 2 + .../editor/src/components/editor/index.tsx | 5 +- .../components/editor/node-arrow-handles.tsx | 3 +- .../editor/quick-measurement-card.tsx | 70 + .../editor/quick-measurement-hud.tsx | 28 + .../tools/wall/wall-drafting.test.ts | 4 + .../tools/zone/zone-boundary-editor.tsx | 6 +- .../ui/action-menu/control-modes.tsx | 72 +- .../ui/action-menu/measurement-control.tsx | 188 ++ .../components/ui/helpers/helper-manager.tsx | 13 + .../keyboard-shortcuts-dialog.tsx | 1 + .../panels/site-panel/registry-tree-node.tsx | 31 +- .../sidebar/panels/site-panel/tree-node.tsx | 1 + .../editor/src/hooks/use-auto-save.test.ts | 14 + packages/editor/src/hooks/use-auto-save.ts | 20 +- packages/editor/src/hooks/use-keyboard.ts | 21 +- packages/editor/src/index.tsx | 54 + .../src/lib/floorplan/floorplan-export.tsx | 6 +- .../editor/src/lib/measurement-kind.test.ts | 30 + packages/editor/src/lib/measurement-kind.ts | 19 + .../editor/src/lib/measurement-label.test.ts | 47 + packages/editor/src/lib/measurement-label.ts | 68 + packages/editor/src/lib/measurements.test.ts | 86 + packages/editor/src/lib/measurements.ts | 123 + packages/editor/src/lib/plugin-panels.test.ts | 19 + packages/editor/src/lib/plugin-panels.ts | 4 + .../editor/src/lib/quick-measurement.test.ts | 77 + packages/editor/src/lib/quick-measurement.ts | 109 + .../editor/src/lib/scene-clipboard.test.ts | 58 + packages/editor/src/lib/scene-clipboard.ts | 6 + packages/editor/src/lib/sfx-bus.ts | 63 +- packages/editor/src/lib/sfx-player.test.ts | 124 + packages/editor/src/lib/sfx-player.ts | 162 +- .../editor/src/lib/surface-plan-snap.test.ts | 71 + packages/editor/src/store/use-editor.tsx | 40 +- .../src/store/use-measurement-draft.test.ts | 530 ++++ .../editor/src/store/use-measurement-draft.ts | 543 +++++ .../store/use-quick-measurement-hud.test.ts | 53 + .../src/store/use-quick-measurement-hud.ts | 77 + packages/nodes/src/ceiling/definition.ts | 12 + .../src/ceiling/floorplan-affordances.ts | 10 +- packages/nodes/src/ceiling/floorplan-move.ts | 7 +- packages/nodes/src/index.ts | 3 + packages/nodes/src/item/model-loader.test.ts | 161 ++ packages/nodes/src/item/model-loader.ts | 156 ++ packages/nodes/src/item/renderer.tsx | 174 +- .../nodes/src/measurement/definition.test.ts | 42 + packages/nodes/src/measurement/definition.ts | 69 + packages/nodes/src/measurement/edit.test.ts | 124 + packages/nodes/src/measurement/edit.ts | 139 ++ .../src/measurement/floorplan-affordance.ts | 127 + .../nodes/src/measurement/floorplan.test.ts | 250 ++ packages/nodes/src/measurement/floorplan.ts | 236 ++ packages/nodes/src/measurement/index.ts | 15 + .../nodes/src/measurement/renderer.test.ts | 22 + packages/nodes/src/measurement/renderer.tsx | 458 ++++ .../nodes/src/measurement/resolve.test.ts | 219 ++ packages/nodes/src/measurement/resolve.ts | 289 +++ packages/nodes/src/measurement/schema.ts | 1 + packages/nodes/src/measurement/selection.tsx | 419 ++++ .../src/measurement/smart-surface.test.ts | 63 + .../nodes/src/measurement/smart-surface.ts | 32 + packages/nodes/src/measurement/smart-tool.tsx | 389 +++ .../src/measurement/surface-query.test.ts | 188 ++ .../nodes/src/measurement/surface-query.ts | 855 +++++++ .../nodes/src/measurement/tool-router.tsx | 10 + packages/nodes/src/measurement/tool.test.ts | 567 +++++ packages/nodes/src/measurement/tool.tsx | 2170 +++++++++++++++++ packages/nodes/src/roof-segment/definition.ts | 12 + .../nodes/src/roof-segment/measurement.ts | 100 + .../src/shared/polygon-measurement.test.ts | 71 + .../nodes/src/shared/polygon-measurement.ts | 52 + .../shared/polygon-vertex-affordance.test.ts | 136 ++ .../src/shared/polygon-vertex-affordance.ts | 54 +- .../src/shared/quick-measurement.test.ts | 73 + .../nodes/src/shared/quick-measurement.ts | 38 + packages/nodes/src/site/definition.ts | 10 + packages/nodes/src/slab/definition.ts | 14 + .../nodes/src/slab/floorplan-affordances.ts | 8 +- packages/nodes/src/slab/quick-measurement.ts | 41 + .../nodes/src/spawn/__tests__/parity.test.ts | 1 + packages/nodes/src/wall/definition.ts | 13 + packages/nodes/src/wall/measurement.test.ts | 20 + packages/nodes/src/wall/measurement.ts | 216 ++ packages/nodes/src/wall/quick-measurement.ts | 39 + packages/nodes/src/zone/definition.ts | 23 +- .../nodes/src/zone/floorplan-affordances.ts | 27 +- packages/nodes/src/zone/floorplan-move.ts | 7 +- packages/nodes/src/zone/floorplan.ts | 10 +- packages/nodes/src/zone/parametrics.ts | 1 + packages/nodes/src/zone/quantities-panel.tsx | 240 ++ packages/nodes/src/zone/quick-measurement.ts | 42 + packages/nodes/src/zone/renderer.tsx | 30 +- .../src/components/viewer/frame-limiter.tsx | 12 +- .../viewer/src/components/viewer/index.tsx | 10 +- .../src/components/viewer/post-processing.tsx | 7 +- .../src/components/viewer/scene-bvh.test.ts | 16 + .../src/components/viewer/scene-bvh.tsx | 3 + packages/viewer/src/store/use-viewer.test.ts | 51 + packages/viewer/src/store/use-viewer.ts | 27 +- wiki/architecture/README.md | 1 + wiki/architecture/measurements.md | 153 ++ 137 files changed, 15492 insertions(+), 330 deletions(-) create mode 100644 packages/core/src/hooks/scene-registry/scene-registry.test.ts create mode 100644 packages/core/src/lib/measurement-geometry.test.ts create mode 100644 packages/core/src/lib/measurement-geometry.ts create mode 100644 packages/core/src/lib/zone-quantities.test.ts create mode 100644 packages/core/src/lib/zone-quantities.ts create mode 100644 packages/core/src/schema/nodes/measurement.test.ts create mode 100644 packages/core/src/schema/nodes/measurement.ts create mode 100644 packages/core/src/store/use-scene-measurement-roundtrip.test.ts create mode 100644 packages/editor/src/components/editor-2d/floorplan-measurement-tool-layer.test.ts create mode 100644 packages/editor/src/components/editor-2d/floorplan-measurement-tool-layer.tsx create mode 100644 packages/editor/src/components/editor-2d/floorplan-quick-measure-layer.tsx create mode 100644 packages/editor/src/components/editor-2d/renderers/floorplan-label-angle.test.ts create mode 100644 packages/editor/src/components/editor-2d/renderers/floorplan-label-angle.ts create mode 100644 packages/editor/src/components/editor/quick-measurement-card.tsx create mode 100644 packages/editor/src/components/editor/quick-measurement-hud.tsx create mode 100644 packages/editor/src/components/ui/action-menu/measurement-control.tsx create mode 100644 packages/editor/src/hooks/use-auto-save.test.ts create mode 100644 packages/editor/src/lib/measurement-kind.test.ts create mode 100644 packages/editor/src/lib/measurement-kind.ts create mode 100644 packages/editor/src/lib/measurement-label.test.ts create mode 100644 packages/editor/src/lib/measurement-label.ts create mode 100644 packages/editor/src/lib/plugin-panels.test.ts create mode 100644 packages/editor/src/lib/quick-measurement.test.ts create mode 100644 packages/editor/src/lib/quick-measurement.ts create mode 100644 packages/editor/src/lib/sfx-player.test.ts create mode 100644 packages/editor/src/lib/surface-plan-snap.test.ts create mode 100644 packages/editor/src/store/use-measurement-draft.test.ts create mode 100644 packages/editor/src/store/use-measurement-draft.ts create mode 100644 packages/editor/src/store/use-quick-measurement-hud.test.ts create mode 100644 packages/editor/src/store/use-quick-measurement-hud.ts create mode 100644 packages/nodes/src/item/model-loader.test.ts create mode 100644 packages/nodes/src/item/model-loader.ts create mode 100644 packages/nodes/src/measurement/definition.test.ts create mode 100644 packages/nodes/src/measurement/definition.ts create mode 100644 packages/nodes/src/measurement/edit.test.ts create mode 100644 packages/nodes/src/measurement/edit.ts create mode 100644 packages/nodes/src/measurement/floorplan-affordance.ts create mode 100644 packages/nodes/src/measurement/floorplan.test.ts create mode 100644 packages/nodes/src/measurement/floorplan.ts create mode 100644 packages/nodes/src/measurement/index.ts create mode 100644 packages/nodes/src/measurement/renderer.test.ts create mode 100644 packages/nodes/src/measurement/renderer.tsx create mode 100644 packages/nodes/src/measurement/resolve.test.ts create mode 100644 packages/nodes/src/measurement/resolve.ts create mode 100644 packages/nodes/src/measurement/schema.ts create mode 100644 packages/nodes/src/measurement/selection.tsx create mode 100644 packages/nodes/src/measurement/smart-surface.test.ts create mode 100644 packages/nodes/src/measurement/smart-surface.ts create mode 100644 packages/nodes/src/measurement/smart-tool.tsx create mode 100644 packages/nodes/src/measurement/surface-query.test.ts create mode 100644 packages/nodes/src/measurement/surface-query.ts create mode 100644 packages/nodes/src/measurement/tool-router.tsx create mode 100644 packages/nodes/src/measurement/tool.test.ts create mode 100644 packages/nodes/src/measurement/tool.tsx create mode 100644 packages/nodes/src/roof-segment/measurement.ts create mode 100644 packages/nodes/src/shared/polygon-measurement.test.ts create mode 100644 packages/nodes/src/shared/polygon-measurement.ts create mode 100644 packages/nodes/src/shared/polygon-vertex-affordance.test.ts create mode 100644 packages/nodes/src/shared/quick-measurement.test.ts create mode 100644 packages/nodes/src/shared/quick-measurement.ts create mode 100644 packages/nodes/src/slab/quick-measurement.ts create mode 100644 packages/nodes/src/wall/measurement.test.ts create mode 100644 packages/nodes/src/wall/measurement.ts create mode 100644 packages/nodes/src/wall/quick-measurement.ts create mode 100644 packages/nodes/src/zone/quantities-panel.tsx create mode 100644 packages/nodes/src/zone/quick-measurement.ts create mode 100644 packages/viewer/src/components/viewer/scene-bvh.test.ts create mode 100644 packages/viewer/src/store/use-viewer.test.ts create mode 100644 wiki/architecture/measurements.md diff --git a/apps/editor/app/client-bootstrap.tsx b/apps/editor/app/client-bootstrap.tsx index 610eac4e..821544fe 100644 --- a/apps/editor/app/client-bootstrap.tsx +++ b/apps/editor/app/client-bootstrap.tsx @@ -11,13 +11,16 @@ import '../lib/bootstrap' import { type ReactNode, useEffect } from 'react' -export function ClientBootstrap({ children }: { children: ReactNode }) { +export function ClientBootstrap({ + children, + enableDevDiagnostics, +}: { + children: ReactNode + enableDevDiagnostics: boolean +}) { useEffect(() => { - if (process.env.NODE_ENV !== 'development') return - // Loaded here (not via a `