From a796c0fd0addcc1b78b016e67516f517f710c36c Mon Sep 17 00:00:00 2001
From: sudhir <sudhir9297@gmail.com>
Date: Mon, 27 Apr 2026 10:57:50 +0530
Subject: [PATCH] Move item dimensions into local item overlays

---
 .../src/components/editor/floorplan-panel.tsx | 29 +++++++-------
 .../tools/item/use-placement-coordinator.tsx  | 38 +++++++++++++------
 2 files changed, 40 insertions(+), 27 deletions(-)

diff --git a/packages/editor/src/components/editor/floorplan-panel.tsx b/packages/editor/src/components/editor/floorplan-panel.tsx
index c9f04231..ff326927 100644
--- a/packages/editor/src/components/editor/floorplan-panel.tsx
+++ b/packages/editor/src/components/editor/floorplan-panel.tsx
@@ -4137,6 +4137,7 @@ const FloorplanNodeLayer = memo(function FloorplanNodeLayer({
   palette,
   selectedIdSet,
   stairEntries,
+  unit,
 }: {
   canFocusItems: boolean
   canFocusStairs: boolean
@@ -4161,12 +4162,15 @@ const FloorplanNodeLayer = memo(function FloorplanNodeLayer({
   palette: FloorplanPalette
   selectedIdSet: ReadonlySet<string>
   stairEntries: FloorplanStairEntry[]
+  unit: 'metric' | 'imperial'
 }) {
   if (itemEntries.length === 0 && stairEntries.length === 0) {
     return null
   }
 
-  const itemNodes = itemEntries.map(({ item, points, polygon }) => {
+  const itemNodes = itemEntries.map((itemEntry) => {
+    const { item, points, polygon } = itemEntry
+    const itemDimensionMeasurements = getItemDimensionMeasurementOverlays(itemEntry, unit)
     const isSelected = selectedIdSet.has(item.id)
     const isHighlighted = highlightedIdSet.has(item.id)
     const isHovered = hoveredItemId === item.id
@@ -4309,6 +4313,13 @@ const FloorplanNodeLayer = memo(function FloorplanNodeLayer({
             y2={toSvgY(diagonalBEnd.y)}
           />
         )}
+        {itemDimensionMeasurements.length > 0 ? (
+          <FloorplanMeasurementsLayer
+            className="item-dimension-measurement"
+            measurements={itemDimensionMeasurements}
+            palette={palette}
+          />
+        ) : null}
       </g>
     )
   })
@@ -6776,15 +6787,6 @@ export function FloorplanPanel() {
     isFenceEndpointMoveActive ||
     isFloorItemBuildActive ||
     isFloorItemMoveActive
-  const itemPlacementDimensionMeasurements = useMemo(() => {
-    if (!isItemPlacementPreviewActive) {
-      return [] as LinearMeasurementOverlay[]
-    }
-
-    return floorplanItemEntries.flatMap((itemEntry) =>
-      getItemDimensionMeasurementOverlays(itemEntry, unit),
-    )
-  }, [floorplanItemEntries, isItemPlacementPreviewActive, unit])
   const floorplanPreviewStairSegment = useMemo(
     () =>
       StairSegmentNodeSchema.parse({
@@ -11988,6 +11990,7 @@ export function FloorplanPanel() {
                 palette={palette}
                 selectedIdSet={selectedIdSet}
                 stairEntries={renderedFloorplanStairEntries}
+                unit={unit}
               />
 
               <FloorplanRoofLayer
@@ -11996,12 +11999,6 @@ export function FloorplanPanel() {
                 selectedIdSet={selectedIdSet}
               />
 
-              <FloorplanMeasurementsLayer
-                className="item-dimension-measurement"
-                measurements={itemPlacementDimensionMeasurements}
-                palette={palette}
-              />
-
               <FloorplanMeasurementsLayer
                 className="opening-placement-dimension"
                 measurements={movingOpeningPlacementMeasurements}
diff --git a/packages/editor/src/components/tools/item/use-placement-coordinator.tsx b/packages/editor/src/components/tools/item/use-placement-coordinator.tsx
index 0ddd1a97..1fb6fe66 100644
--- a/packages/editor/src/components/tools/item/use-placement-coordinator.tsx
+++ b/packages/editor/src/components/tools/item/use-placement-coordinator.tsx
@@ -17,8 +17,8 @@ import {
 } from '@pascal-app/core'
 import { useViewer } from '@pascal-app/viewer'
 import { Html } from '@react-three/drei'
-import { useFrame } from '@react-three/fiber'
-import { useEffect, useRef } from 'react'
+import { createPortal, useFrame } from '@react-three/fiber'
+import { useEffect, useRef, useState } from 'react'
 import {
   BoxGeometry,
   Box3,
@@ -221,6 +221,10 @@ export function usePlacementCoordinator(config: PlacementCoordinatorConfig): Rea
   const previewBoundsSignatureRef = useRef<string | null>(null)
   const meshPreviewAppliedRef = useRef(false)
   const dimensionBoundsRef = useRef<PreviewBounds | null>(null)
+  const [measurementTargetState, setMeasurementTargetState] = useState<{
+    id: string
+    object: Object3D
+  } | null>(null)
 
   // Store config callbacks in refs to avoid re-running effect when they change
   const configRef = useRef(config)
@@ -1172,6 +1176,12 @@ export function usePlacementCoordinator(config: PlacementCoordinatorConfig): Rea
     if (!draftNode.current) return
     const mesh = sceneRegistry.nodes.get(draftNode.current.id)
     if (!mesh) return
+    if (
+      measurementTargetState?.id !== draftNode.current.id ||
+      measurementTargetState.object !== mesh
+    ) {
+      setMeasurementTargetState({ id: draftNode.current.id, object: mesh })
+    }
 
     if (!meshPreviewAppliedRef.current) {
       const previewBounds = getPreviewBoundsFromObject(mesh)
@@ -1207,10 +1217,6 @@ export function usePlacementCoordinator(config: PlacementCoordinatorConfig): Rea
           draftNode.current.rotation,
         )
         mesh.position.y = slabElevation
-        // Cursor group is at the world root (not inside a level group), so add the
-        // level group's current world Y to convert from level-local to world space.
-        const levelGroup = sceneRegistry.nodes.get(levelId as AnyNodeId)
-        cursorGroupRef.current.position.y = slabElevation + (levelGroup?.position.y ?? 0)
       }
     }
   })
@@ -1247,11 +1253,12 @@ export function usePlacementCoordinator(config: PlacementCoordinatorConfig): Rea
     initialDimensionBounds.center[2] - initialDimensionBounds.dimensions[2] / 2,
   ]
 
-  return (
-    <group ref={cursorGroupRef}>
-      <lineSegments layers={EDITOR_LAYER} material={edgeMaterial} ref={edgesRef} renderOrder={999}>
-        <edgesGeometry args={[initialBoxGeometry]} />
-      </lineSegments>
+  const measurementTarget =
+    draftNode.current && measurementTargetState?.id === draftNode.current.id
+      ? measurementTargetState.object
+      : null
+  const measurementContent = (
+    <>
       <lineSegments
         layers={EDITOR_LAYER}
         material={measurementMaterial}
@@ -1330,6 +1337,15 @@ export function usePlacementCoordinator(config: PlacementCoordinatorConfig): Rea
           {heightLabel}
         </div>
       </Html>
+    </>
+  )
+
+  return (
+    <group ref={cursorGroupRef}>
+      <lineSegments layers={EDITOR_LAYER} material={edgeMaterial} ref={edgesRef} renderOrder={999}>
+        <edgesGeometry args={[initialBoxGeometry]} />
+      </lineSegments>
+      {measurementTarget ? createPortal(measurementContent, measurementTarget) : measurementContent}
       <mesh
         geometry={basePlaneGeometry}
         layers={EDITOR_LAYER}