From a7734b8ffeac651d5e556300b296854131d84a9a Mon Sep 17 00:00:00 2001 From: Aymeric Rabot Date: Sun, 19 Jul 2026 17:54:38 +0200 Subject: [PATCH] test(nodes): isolate cabinet regression suites (#517) --- .../nodes/src/cabinet/__tests__/geometry.test.ts | 15 ++++++++++++--- .../cabinet/__tests__/wall-depth-handles.test.ts | 13 ++----------- packages/nodes/src/wall/treatments.test.ts | 11 ++--------- 3 files changed, 16 insertions(+), 23 deletions(-) diff --git a/packages/nodes/src/cabinet/__tests__/geometry.test.ts b/packages/nodes/src/cabinet/__tests__/geometry.test.ts index c064c1d7..3411d9e1 100644 --- a/packages/nodes/src/cabinet/__tests__/geometry.test.ts +++ b/packages/nodes/src/cabinet/__tests__/geometry.test.ts @@ -2319,9 +2319,17 @@ describe('cabinet handles', () => { sceneApi: ReturnType, ) => HandleDescriptor[] const depthHandles = buildHandles(source, fixture.sceneApi).filter( - (handle): handle is LinearResizeHandle => - handle.kind === 'linear-resize' && - handle.visible?.(source, fixture.sceneApi as never) !== false, + (handle): handle is LinearResizeHandle => { + if ( + handle.kind !== 'linear-resize' || + handle.visible?.(source, fixture.sceneApi as never) === false + ) { + return false + } + const targetId = handle.overrideTarget?.(source, fixture.sceneApi as never) ?? source.id + const target = fixture.sceneApi.get(targetId) + return target?.type === 'cabinet' && target.runTier === 'base' + }, ) return { ...fixture, depthHandles, source, thirdRun } } @@ -2613,6 +2621,7 @@ describe('cabinet handles', () => { [run, ...modules].map((node) => [node.id as AnyNodeId, node as AnyNode]), ) as Record const sceneApi = { + get: (id: AnyNodeId) => nodes[id], nodes: () => nodes, } const rotateHandle = ( diff --git a/packages/nodes/src/cabinet/__tests__/wall-depth-handles.test.ts b/packages/nodes/src/cabinet/__tests__/wall-depth-handles.test.ts index 1c44cc7b..09bac411 100644 --- a/packages/nodes/src/cabinet/__tests__/wall-depth-handles.test.ts +++ b/packages/nodes/src/cabinet/__tests__/wall-depth-handles.test.ts @@ -1,4 +1,4 @@ -import { describe, expect, mock, test } from 'bun:test' +import { describe, expect, test } from 'bun:test' import type { AnyNode, AnyNodeId, @@ -8,19 +8,10 @@ import type { LinearResizeHandle, SceneApi, } from '@pascal-app/core' +import { cabinetDefinition, cabinetModuleDefinition } from '../definition' import { addCornerRun } from '../run-ops' import { CabinetModuleNode, CabinetNode } from '../schema' -mock.module('../floorplan-move', () => ({ cabinetModuleFloorplanMoveTarget: () => null })) -mock.module('../floorplan', () => ({ - buildCabinetFloorplan: () => null, - buildCabinetModuleFloorplan: () => null, -})) -mock.module('../geometry', () => ({ buildCabinetGeometry: () => null })) -mock.module('../paint', () => ({ cabinetPaint: {} })) - -const { cabinetDefinition, cabinetModuleDefinition } = await import('../definition') - function wallDepthFixture() { const root = { ...CabinetNode.parse({ diff --git a/packages/nodes/src/wall/treatments.test.ts b/packages/nodes/src/wall/treatments.test.ts index e20ee3d3..a54799b9 100644 --- a/packages/nodes/src/wall/treatments.test.ts +++ b/packages/nodes/src/wall/treatments.test.ts @@ -1,14 +1,7 @@ -import { describe, expect, mock, test } from 'bun:test' +import { describe, expect, test } from 'bun:test' import type { WallNode, WallTrimConfig } from '@pascal-app/core' import { buildWallTreatmentLevelData } from './treatment-level-data' - -mock.module('@pascal-app/viewer', () => ({ - baseMaterial: () => undefined, - createMaterialFromPresetRef: () => undefined, - resolveMaterialRef: () => undefined, -})) - -const { buildTrimGeometry, wallTreatmentProudOffsets } = await import('./treatments') +import { buildTrimGeometry, wallTreatmentProudOffsets } from './treatments' function wall(id: string, start: [number, number], end: [number, number]): WallNode { return {