* fix: resolve lint and type errors to enable CI - Remove stale biome-ignore suppressions in bootstrap.ts, r3f.d.ts, and parametric-node-renderer.tsx (rules no longer fire). - Replace forEach callbacks that return values with for...of loops in node-actions.ts and build-collider-world.ts (lint/suspicious/useIterableCallbackReturn). - Rewrite assign-in-expression guards in ceiling/tool.tsx to explicit if-statements (lint/suspicious/noAssignInExpressions). - Hoist useMemo/useCallback above early return in chimney/panel.tsx (lint/correctness/useHookAtTopLevel). - Add `^build` to turbo check-types dependsOn so packages/core dist is up-to-date before type checking — this resolves all 32 type errors which were caused by stale dist, not missing symbols. * ci: add lint and typecheck workflow on push/PR Adds a quality gate that runs `bun run check` (Biome) and `bun run check-types` (TypeScript) on every push and PR to main. Uses concurrency groups to cancel stale runs. Closes #147. --------- Co-authored-by: Pascal <open@pascal.app>
This commit is contained in:
@@ -50,9 +50,6 @@ type RenderableNode = AnyNode & {
|
||||
export const ParametricNodeRenderer = ({ node }: { node: AnyNode }) => {
|
||||
const ref = useRef<Group>(null!)
|
||||
const n = node as RenderableNode
|
||||
// biome-ignore lint/suspicious/noExplicitAny: useNodeEvents is keyed by
|
||||
// literal kind; the registry path passes a runtime kind union. Routing
|
||||
// through the type cast is safer than widening the hook signature.
|
||||
const handlers = useNodeEvents(node as any, node.type as any)
|
||||
const liveTransform = useLiveTransforms((s) => s.get(node.id as AnyNodeId))
|
||||
// Registry arrow handles (rotation gizmo, position-affecting patches)
|
||||
|
||||
Vendored
-3
@@ -78,21 +78,18 @@ interface ThreeJSXElements {
|
||||
}
|
||||
|
||||
declare module 'react' {
|
||||
// biome-ignore lint/style/noNamespace: Required for JSX module augmentation
|
||||
namespace JSX {
|
||||
interface IntrinsicElements extends ThreeJSXElements {}
|
||||
}
|
||||
}
|
||||
|
||||
declare module 'react/jsx-runtime' {
|
||||
// biome-ignore lint/style/noNamespace: Required for JSX module augmentation
|
||||
namespace JSX {
|
||||
interface IntrinsicElements extends ThreeJSXElements {}
|
||||
}
|
||||
}
|
||||
|
||||
declare module 'react/jsx-dev-runtime' {
|
||||
// biome-ignore lint/style/noNamespace: Required for JSX module augmentation
|
||||
namespace JSX {
|
||||
interface IntrinsicElements extends ThreeJSXElements {}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user