* fix: resolve lint and type errors to enable CI - Remove stale biome-ignore suppressions in bootstrap.ts, r3f.d.ts, and parametric-node-renderer.tsx (rules no longer fire). - Replace forEach callbacks that return values with for...of loops in node-actions.ts and build-collider-world.ts (lint/suspicious/useIterableCallbackReturn). - Rewrite assign-in-expression guards in ceiling/tool.tsx to explicit if-statements (lint/suspicious/noAssignInExpressions). - Hoist useMemo/useCallback above early return in chimney/panel.tsx (lint/correctness/useHookAtTopLevel). - Add `^build` to turbo check-types dependsOn so packages/core dist is up-to-date before type checking — this resolves all 32 type errors which were caused by stale dist, not missing symbols. * ci: add lint and typecheck workflow on push/PR Adds a quality gate that runs `bun run check` (Biome) and `bun run check-types` (TypeScript) on every push and PR to main. Uses concurrency groups to cancel stale runs. Closes #147. --------- Co-authored-by: Pascal <open@pascal.app>
This commit is contained in:
@@ -45,7 +45,6 @@ function loadBuiltinsSync(): void {
|
||||
if (isDev()) {
|
||||
const kinds = Array.from(nodeRegistry.entries(), ([k]) => k)
|
||||
if (typeof console !== 'undefined') {
|
||||
// biome-ignore lint/suspicious/noConsole: dev-only verification log
|
||||
console.info(
|
||||
`[pascal:registry] loaded ${builtinPlugin.id} v${builtinPlugin.apiVersion} (${kinds.length} kinds: ${kinds.join(', ') || '∅'})`,
|
||||
)
|
||||
@@ -74,7 +73,6 @@ export async function loadExternalPlugins(): Promise<void> {
|
||||
await loadPlugin(plugin)
|
||||
}
|
||||
if (isDev() && externals.length > 0 && typeof console !== 'undefined') {
|
||||
// biome-ignore lint/suspicious/noConsole: dev-only verification log
|
||||
console.info(`[pascal:registry] + ${externals.length} discovered plugin(s)`)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user