perf(editor): stabilize 3D opening-guide rendering, remove per-tick GPU churn

Reuse one THREE.Line + preallocated position buffer per guide slot, mutating
endpoints in place each drag tick instead of rebuilding the geometry, line, and
two Vector3s and re-uploading the GPU buffer every frame. Key guides by a stable
semantic id (sill / head / gap:side / vertical / spacing:i) so a slot that
persists keeps its React element and drei <Html> pill mounted as the guide set
churns, rather than remounting under shifting index keys.

Also: make useOpeningGuides.clear() a no-op when already empty so the common
no-guide hover frame doesn't push a fresh [] and re-render to the same nothing;
dispose the move-tool cursor EdgesGeometry on unmount; and memoize the
placement-tool cursor EdgesGeometry (static fallback dims) so it isn't
reallocated and orphaned on every render during placement.

Reviewed by Codex (peer + adversarial): no correctness, hook-order, or GPU-leak
regressions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

This commit is contained in:

Aymeric Rabot

2026-06-15 12:36:06 -04:00

co-authored by

Claude Opus 4.8

parent 86e9b3c8bf

commit 69aa272004

7 changed files with 77 additions and 32 deletions

									
										packages/nodes/src/window/move-tool.tsx
									
		+1
		
												View File
												
				@@ -702,6 +702,7 @@ const MoveWindowTool: React.FC<{ node: WindowNode }> = ({ node: movingWindowNode

				    boxGeo.dispose()

				    return geo

				  }, [movingWindowNode])

				  useEffect(() => () => edgesGeo.dispose(), [edgesGeo])

				  return (

				    <group ref={cursorGroupRef} visible={false}>