From 3d5a36c73d85ee71e83c5318f905f4669519f34a Mon Sep 17 00:00:00 2001
From: Wassim SAMAD <wass08@gmail.com>
Date: Mon, 15 Jun 2026 17:17:44 -0400
Subject: [PATCH] feat(render-modes): items show real materials in colored mode
 (not flat clay)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In colored mode (textures on), every item now renders its authored material
— textures, vertex colours, and default colours — instead of being stripped
to the uniform off-white baseMaterial. AI-generated and vertex-coloured items
show their real appearance; slot resolution (override -> curated -> authored)
is unchanged. Monochrome (textures off) still collapses to the furnishing
clay role colour (the escape hatch). Drops the now-unused isAuthored marker.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 packages/nodes/src/item/renderer.tsx | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/packages/nodes/src/item/renderer.tsx b/packages/nodes/src/item/renderer.tsx
index 5e7586ec..dc18848c 100644
--- a/packages/nodes/src/item/renderer.tsx
+++ b/packages/nodes/src/item/renderer.tsx
@@ -9,16 +9,15 @@ import {
   type ItemNode,
   isSlotMaterialName,
   LIBRARY_MATERIAL_REF_PREFIX,
+  type LightEffect,
   SCENE_MATERIAL_REF_PREFIX,
   toLibraryMaterialRef,
-  type LightEffect,
   useInteractive,
   useLiveNodeOverrides,
   useRegistry,
   useScene,
 } from '@pascal-app/core'
 import {
-  baseMaterial,
   type ColorPreset,
   createDefaultMaterial,
   createSurfaceRoleMaterial,
@@ -121,11 +120,6 @@ const captureItemMeshMaterials = (mesh: Mesh): CapturedItemMaterialData => {
   return next
 }
 
-const hasCapturedSlot = (captured: CapturedItemMaterialData): boolean =>
-  Array.isArray(captured.slotIds)
-    ? captured.slotIds.some((slotId) => slotId != null)
-    : captured.slotIds != null
-
 const isCapturedMaterialArray = (
   captured: CapturedItemMaterialData,
 ): captured is CapturedMultiItemMaterialData => Array.isArray(captured.authoredMaterials)
@@ -155,20 +149,19 @@ const resolveItemMaterial = (
   curatedRef: string | undefined,
   {
     colorPreset,
-    isAuthored,
     nodeSlots,
     sceneMaterials,
     shading,
     textures,
   }: {
     colorPreset: ColorPreset
-    isAuthored: boolean
     nodeSlots: ItemNode['slots']
     sceneMaterials: SceneMaterials
     shading: RenderShading
     textures: boolean
   },
 ): Material => {
+  // Monochrome (textures off): collapse to the themed furnishing clay colour.
   if (!textures) return createSurfaceRoleMaterial('furnishing', colorPreset)
   if (authoredMaterial.name.toLowerCase() === 'glass') return glassMaterial
   if (slotId != null) {
@@ -178,8 +171,10 @@ const resolveItemMaterial = (
     if (curated) return curated
     return authoredMaterial
   }
-  if (isAuthored) return authoredMaterial
-  return baseMaterial(shading)
+  // Colored (textures on): show the item's real authored material — its
+  // textures, vertex colours, and default colours — for every item, not just
+  // slot-authored ones (no more strip-to-clay default).
+  return authoredMaterial
 }
 
 const BrokenItemFallback = ({ node }: { node: ItemNode }) => {
@@ -334,7 +329,6 @@ const ModelRenderer = ({ node }: { node: ItemNode }) => {
     if (!root) return
 
     const meshEntries: { mesh: Mesh; captured: CapturedItemMaterialData }[] = []
-    let isAuthored = false
 
     root.traverse((child) => {
       if (!(child as Mesh).isMesh) return
@@ -345,13 +339,11 @@ const ModelRenderer = ({ node }: { node: ItemNode }) => {
       }
 
       const captured = captureItemMeshMaterials(mesh)
-      if (hasCapturedSlot(captured)) isAuthored = true
       if (mesh.name !== 'cutout') meshEntries.push({ mesh, captured })
     })
 
     const materialOptions = {
       colorPreset,
-      isAuthored,
       nodeSlots: node.slots,
       sceneMaterials,
       shading,